Merge pull request #109 from Automattic/ignore-locate-template-in-include-sniff

Ignore `locate_template` in IncludingFile sniff

Author: david-binda

WordPressVIPMinimum/Sniffs/Files/IncludingFileSniff.php

@@ -25,11 +25,12 @@ class IncludingFileSniff implements \PHP_CodeSniffer_Sniff {
 	 *
 	 * @var array
 	 */
-	public $getPathFuncitons = array(
+	public $getPathFunctions = array(
 		'plugin_dir_path',
 		'dirname',
 		'get_stylesheet_directory',
 		'get_template_directory',
+		'locate_template',
 	);
 
 	/**
@@ -106,7 +107,7 @@ public function process( File $phpcsFile, $stackPtr ) {
 
 		if ( T_STRING === $tokens[ $nextToken ]['code'] ) {
 
-			if ( true === in_array( $tokens[ $nextToken ]['content'], $this->getPathFuncitons, true ) ) {
+			if ( true === in_array( $tokens[ $nextToken ]['content'], $this->getPathFunctions, true ) ) {
 				// The construct is using one of the function for getting correct path which is fine.
 				return;
 			}

WordPressVIPMinimum/Tests/Files/IncludingFileUnitTest.inc

@@ -8,4 +8,6 @@ include( __DIR__ . "/my_file.php" ); // OK.
 
 include ( MY_CONSTANT . "my_file.php" ); // Warning.
 
-require_once ( MY_CONSTANT . "my_file.php" ); // Warning.
+require_once ( MY_CONSTANT . "my_file.php" ); // Warning.
+
+include( locate_template('index-loop.php') ); // Ok.