Addressing PHPCS feedback

Author: david-binda

WordPressVIPMinimum/Sniffs/VIP/ProperEscapingFunctionSniff.php

@@ -18,6 +18,11 @@
  */
 class ProperEscapingFunctionSniff implements \PHP_CodeSniffer_Sniff {
 
+	/**
+	 * List of escaping functions which are being tested.
+	 *
+	 * @var array
+	 */
 	public $escaping_functions = array(
 		'esc_url',
 		'esc_attr',
@@ -66,7 +71,6 @@ public function process( File $phpcsFile, $stackPtr ) {
 			if ( T_INLINE_HTML !== $tokens[ $html ]['code'] ) {
 				return;
 			}
-
 		} elseif ( T_STRING_CONCAT === $tokens[ $echo_or_string_concat ]['code'] ) {
 			// Very likely string concatenation mixing strings and functions/variables.
 			$html = $phpcsFile->findPrevious( Tokens::$emptyTokens, ( $echo_or_string_concat - 1 ), null, true );
@@ -93,7 +97,7 @@ public function process( File $phpcsFile, $stackPtr ) {
 	/**
 	 * Tests whether provided string ends with open src or href attribute.
 	 *
-	 * @param $content Haystak in which we look for an open src or href attribute.
+	 * @param string $content Haystack in which we look for an open src or href attribute.
 	 *
 	 * @return bool True if string ends with open src or href attribute.
 	 */
@@ -147,6 +151,6 @@ public function is_html_attr( $content ) {
 	 * @return bool True if haystack ends with needle.
 	 */
 	public function endswith( $haystack, $needle ) {
-		return $needle === substr( $haystack, -strlen( $needle ) );
+		return substr( $haystack, -strlen( $needle ) ) === $needle;
 	}
 }