feat: increase to type coverage level 21

Author: Art4

.rector.php

@@ -13,7 +13,7 @@
     //->withPhpSets()
     ->withPhp74Sets()
     ->withPhpVersion(70400)
-    ->withTypeCoverageLevel(13)
+    ->withTypeCoverageLevel(21)
     ->withPreparedSets(
         true,
         true

composer.json

@@ -30,7 +30,7 @@
         "psr/http-factory": "^1.0"
     },
     "require-dev": {
-        "art4/rector-bc-library": "dev-main",
+        "art4/rector-bc-library": "dev-main#1cf3b8908e28b2bebc2fb26f7d151491dd23471f",
         "behat/behat": "^3.14",
         "friendsofphp/php-cs-fixer": "^3.68",
         "guzzlehttp/psr7": "^2",

tests/Behat/Bootstrap/FeatureContext.php

@@ -45,7 +45,7 @@ final class FeatureContext implements Context
     /**
      * @BeforeSuite
      */
-    public static function prepare(BeforeSuiteScope $scope)
+    public static function prepare(BeforeSuiteScope $scope): void
     {
         self::$tracer = new BehatHookTracer();
         self::$tracer->hook($scope);
@@ -54,15 +54,15 @@ public static function prepare(BeforeSuiteScope $scope)
     /**
      * @AfterScenario
      */
-    public static function reset(AfterScenarioScope $scope)
+    public static function reset(AfterScenarioScope $scope): void
     {
         self::$tracer->hook($scope);
     }
 
     /**
      * @AfterSuite
      */
-    public static function clean(AfterSuiteScope $scope)
+    public static function clean(AfterSuiteScope $scope): void
     {
         self::$tracer->hook($scope);
         self::$tracer = null;
@@ -95,7 +95,7 @@ public function __construct(string $redmineVersion, string $rootPath)
     /**
      * @Given I have a :clientName client
      */
-    public function iHaveAClient($clientName)
+    public function iHaveAClient($clientName): void
     {
         if ($clientName !== 'NativeCurlClient') {
             throw new InvalidArgumentException('Client ' . $clientName . ' is not supported.');
@@ -122,7 +122,7 @@ private function registerClientResponse(mixed $lastReturn, Response $lastRespons
     /**
      * @Then the response has the status code :statusCode
      */
-    public function theResponseHasTheStatusCode(int $statusCode)
+    public function theResponseHasTheStatusCode(int $statusCode): void
     {
         TestCase::assertSame(
             $statusCode,
@@ -134,7 +134,7 @@ public function theResponseHasTheStatusCode(int $statusCode)
     /**
      * @Then the response has the content type :contentType
      */
-    public function theResponseHasTheContentType(string $contentType)
+    public function theResponseHasTheContentType(string $contentType): void
     {
         TestCase::assertStringStartsWith(
             $contentType,
@@ -146,87 +146,87 @@ public function theResponseHasTheContentType(string $contentType)
     /**
      * @Then the response has an empty content type
      */
-    public function theResponseHasAnEmptyContentType()
+    public function theResponseHasAnEmptyContentType(): void
     {
         TestCase::assertSame('', $this->lastResponse->getContentType());
     }
 
     /**
      * @Then the response has the content :content
      */
-    public function theResponseHasTheContent(string $content)
+    public function theResponseHasTheContent(string $content): void
     {
         TestCase::assertSame($content, $this->lastResponse->getContent());
     }
 
     /**
      * @Then the response has the content
      */
-    public function theResponseHasTheContentWithMultipleLines(PyStringNode $string)
+    public function theResponseHasTheContentWithMultipleLines(PyStringNode $string): void
     {
         TestCase::assertSame($string->getRaw(), $this->lastResponse->getContent());
     }
 
     /**
      * @Then the returned data is true
      */
-    public function theReturnedDataIsTrue()
+    public function theReturnedDataIsTrue(): void
     {
         TestCase::assertTrue($this->lastReturn);
     }
 
     /**
      * @Then the returned data is false
      */
-    public function theReturnedDataIsFalse()
+    public function theReturnedDataIsFalse(): void
     {
         TestCase::assertFalse($this->lastReturn);
     }
 
     /**
      * @Then the returned data is exactly :content
      */
-    public function theReturnedDataIsExactly(string $content)
+    public function theReturnedDataIsExactly(string $content): void
     {
         TestCase::assertSame($content, $this->lastReturn);
     }
 
     /**
      * @Then the returned data is exactly
      */
-    public function theReturnedDataIsExactlyWithMultipleLines(PyStringNode $string)
+    public function theReturnedDataIsExactlyWithMultipleLines(PyStringNode $string): void
     {
         TestCase::assertSame($string->getRaw(), $this->lastReturn);
     }
 
     /**
      * @Then the returned data is an instance of :className
      */
-    public function theReturnedDataIsAnInstanceOf(string $className)
+    public function theReturnedDataIsAnInstanceOf(string $className): void
     {
         TestCase::assertInstanceOf($className, $this->lastReturn);
     }
 
     /**
      * @Then the returned data is an array
      */
-    public function theReturnedDataIsAnArray()
+    public function theReturnedDataIsAnArray(): void
     {
         TestCase::assertIsArray($this->lastReturn);
     }
 
     /**
      * @Then the returned data contains :count items
      */
-    public function theReturnedDataContainsItems(int $count)
+    public function theReturnedDataContainsItems(int $count): void
     {
         TestCase::assertCount($count, $this->lastReturn);
     }
 
     /**
      * @Then the returned data contains the following data
      */
-    public function theReturnedDataContainsTheFollowingData(TableNode $table)
+    public function theReturnedDataContainsTheFollowingData(TableNode $table): void
     {
         $returnData = $this->lastReturn;
 
@@ -240,23 +240,23 @@ public function theReturnedDataContainsTheFollowingData(TableNode $table)
     /**
      * @Then the returned data has only the following properties
      */
-    public function theReturnedDataHasOnlyTheFollowingProperties(PyStringNode $string)
+    public function theReturnedDataHasOnlyTheFollowingProperties(PyStringNode $string): void
     {
         $this->theReturnedDataPropertyHasOnlyTheFollowingProperties(null, $string);
     }
 
     /**
      * @Then the returned data has proterties with the following data
      */
-    public function theReturnedDataHasProtertiesWithTheFollowingData(TableNode $table)
+    public function theReturnedDataHasProtertiesWithTheFollowingData(TableNode $table): void
     {
         $this->theReturnedDataPropertyContainsTheFollowingData(null, $table);
     }
 
     /**
      * @Then the returned data :property property is an array
      */
-    public function theReturnedDataPropertyIsAnArray($property)
+    public function theReturnedDataPropertyIsAnArray($property): void
     {
         $returnData = $this->getLastReturnAsArray();
 
@@ -268,7 +268,7 @@ public function theReturnedDataPropertyIsAnArray($property)
     /**
      * @Then the returned data :property property contains :count items
      */
-    public function theReturnedDataPropertyContainsItems($property, int $count)
+    public function theReturnedDataPropertyContainsItems($property, int $count): void
     {
         $returnData = $this->getLastReturnAsArray();
 
@@ -281,7 +281,7 @@ public function theReturnedDataPropertyContainsItems($property, int $count)
     /**
      * @Then the returned data :property property contains the following data
      */
-    public function theReturnedDataPropertyContainsTheFollowingData($property, TableNode $table)
+    public function theReturnedDataPropertyContainsTheFollowingData($property, TableNode $table): void
     {
         $returnData = $this->getItemFromArray($this->getLastReturnAsArray(), $property);
 
@@ -295,7 +295,7 @@ public function theReturnedDataPropertyContainsTheFollowingData($property, Table
     /**
      * @Then the returned data :property property contains the following data with Redmine version :versionComparision
      */
-    public function theReturnedDataPropertyContainsTheFollowingDataWithRedmineVersion($property, string $versionComparision, TableNode $table)
+    public function theReturnedDataPropertyContainsTheFollowingDataWithRedmineVersion($property, string $versionComparision, TableNode $table): void
     {
         $parts = explode(' ', $versionComparision);
 
@@ -313,7 +313,7 @@ public function theReturnedDataPropertyContainsTheFollowingDataWithRedmineVersio
     /**
      * @Then the returned data :property property has only the following properties
      */
-    public function theReturnedDataPropertyHasOnlyTheFollowingProperties($property, PyStringNode $string)
+    public function theReturnedDataPropertyHasOnlyTheFollowingProperties($property, PyStringNode $string): void
     {
         $value = $this->getItemFromArray($this->getLastReturnAsArray(), $property);
 
@@ -325,7 +325,7 @@ public function theReturnedDataPropertyHasOnlyTheFollowingProperties($property,
     /**
      * @Then the returned data :property property has only the following properties with Redmine version :versionComparision
      */
-    public function theReturnedDataPropertyHasOnlyTheFollowingPropertiesWithRedmineVersion($property, string $versionComparision, PyStringNode $string)
+    public function theReturnedDataPropertyHasOnlyTheFollowingPropertiesWithRedmineVersion($property, string $versionComparision, PyStringNode $string): void
     {
         $parts = explode(' ', $versionComparision);
 
@@ -388,7 +388,7 @@ private function getItemFromArray(array $array, $key): mixed
         return $array;
     }
 
-    private function assertTableNodeIsSameAsArray(TableNode $table, array $data)
+    private function assertTableNodeIsSameAsArray(TableNode $table, array $data): void
     {
         foreach ($table as $row) {
             TestCase::assertArrayHasKey($row['property'], $data, 'Possible keys are: ' . implode(', ', array_keys($data)));

tests/Fixtures/AssertingHttpClient.php

@@ -57,7 +57,7 @@ private function assertRequestData(
         int $responseCode = 200,
         string $responseContentType = '',
         string $responseContent = ''
-    ) {
+    ): void {
         if ($responseContentType === '') {
             $responseContentType = $contentType;
         }

tests/RedmineExtension/RedmineInstance.php

@@ -160,7 +160,7 @@ public function excecuteDatabaseQuery(string $query, array $options = [], ?array
         $stmt->execute($params);
     }
 
-    private function runDatabaseMigration()
+    private function runDatabaseMigration(): void
     {
         $now = new DateTimeImmutable();
         $pdo = new PDO('sqlite:' . $this->dataPath . $this->workingDB);
@@ -196,7 +196,7 @@ private function runDatabaseMigration()
     /**
      * Create backup of working database
      */
-    private function createDatabaseBackup()
+    private function createDatabaseBackup(): void
     {
         $workingDB = new SQLite3($this->dataPath . $this->workingDB);
 
@@ -211,7 +211,7 @@ private function createDatabaseBackup()
     /**
      * Create backup of migrated database
      */
-    private function saveMigratedDatabase()
+    private function saveMigratedDatabase(): void
     {
         $workingDB = new SQLite3($this->dataPath . $this->workingDB);
 
@@ -253,7 +253,7 @@ private function removeDatabaseBackups(): void
         unlink($this->dataPath . $this->backupDB);
     }
 
-    private function createFilesBackup()
+    private function createFilesBackup(): void
     {
         // Add an empty file to avoid warnings about copying and removing content from an empty folder
         touch($this->dataPath . $this->workingFiles . 'empty');
@@ -264,7 +264,7 @@ private function createFilesBackup()
         ));
     }
 
-    private function saveMigratedFiles()
+    private function saveMigratedFiles(): void
     {
         exec(sprintf(
             'cp -r %s %s',