Skip to content

Commit 859478c

Browse files
committed
Fix: Exposes AWS keys and secrets #21
Fix: Sidebar icons sizing inconsistency #24
1 parent 9e8d319 commit 859478c

File tree

4 files changed

+22
-21
lines changed

4 files changed

+22
-21
lines changed

package-lock.json

Lines changed: 8 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
"test:unit": "vue-cli-service test:unit --coverage"
1717
},
1818
"dependencies": {
19-
"aws-sdk": "^2.392.0",
19+
"aws-sdk": "^2.395.0",
2020
"electron-default-menu": "^1.0.1",
21-
"element-ui": "^2.4.11",
21+
"element-ui": "^2.5.2",
2222
"lodash": "^4.17.11",
2323
"vue": "^2.5.22",
2424
"vue-awesome": "^3.3.1",

src/components/ConnectDatabase.vue

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@
1212
el-option(v-for="(region, index) in regionList" :key="index" :label="region" :value="region")
1313
el-form-item(label="Access Key Id" required)
1414
el-input(v-model="configs.accessKeyId" placeholder="AWS access key id")
15-
el-form-item(label="Secret Access Key" @keyup.enter.native="submitRemoteForm" required)
16-
el-input(v-model="configs.secretAccessKey" placeholder="AWS secret access key")
15+
el-form-item(label="Secret Access Key" @keyup.enter.native="submitRemoteForm" required)
16+
el-input(v-model="configs.secretAccessKey" :type="inputType" placeholder="AWS secret access key")
17+
template(slot="append")
18+
el-button(icon="el-icon-view" @click="showSecretKey")
1719
ActionButtons(
1820
:cancelHandler="setToDefault"
1921
:confirmHandler="submitRemoteForm"
@@ -50,6 +52,7 @@
5052
},
5153
})
5254
export default class ConnectDatabase extends Vue {
55+
private inputType: string = 'password';
5356
@Prop(Function) private submitRemoteForm: any;
5457
@Prop(Function) private submitLocalForm: any;
5558
@Prop(Function) private setToDefault: any;
@@ -60,6 +63,13 @@
6063
private mounted() {
6164
this.setToDefault();
6265
}
66+
private showSecretKey() {
67+
if (this.inputType === 'password') {
68+
this.inputType = 'text';
69+
} else {
70+
this.inputType = 'password';
71+
}
72+
}
6373
}
6474
</script>
6575

src/components/SidebarTables.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
el-row(class="container")
2121
.list-item(v-for="(table, index) in tableList" :key="index" @click="switchTable(table)" :class="{active: isActive(table)}")
2222
.info
23-
v-icon(name="list-alt" class="icon")
2423
span {{ table }}
2524
span(v-if="!tableList.length") Empty database
2625
</template>

0 commit comments

Comments
 (0)