Add hideToolbarsOnTap prop (#150)

* Add hideToolbarsOnTap prop

* android

Co-authored-by: sgong-pdftron <sgong@pdftron.com>

Author: dluco

README.md

@@ -360,6 +360,7 @@ A component for displaying documents of different types such as PDF, docx, pptx,
 - [pageNumber](#pagenumber)
 - [topToolbarEnabled](#toptoolbarenabled)
 - [bottomToolbarEnabled](#bottomtoolbarenabled)
+- [hideToolbarsOnTap](#hidetoolbarsontap)
 - [pageIndicatorEnabled](#pageindicatorenabled)
 - [showSavedSignatures](#showsavedsignatures)
 - [isBase64String](#isbase64string)
@@ -429,6 +430,11 @@ pageNumber | int | the current page number
 bool, optional
 ##### bottomToolbarEnabled
 bool, optional
+##### hideToolbarsOnTap
+bool, optional
+
+Whether an unhandled tap in the viewer should toggle the visibility of the top and bottom toolbars. The default value is `true`. When `false`, the top and bottom toolbar visibility will not be toggled and the page content will fit between the bars, if any.
+
 ##### pageIndicatorEnabled
 bool, optional
 ##### showSavedSignatures

android/src/main/java/com/pdftron/reactnative/viewmanagers/DocumentViewViewManager.java

@@ -107,6 +107,11 @@ public void setBottomToolbarEnabled(DocumentView documentView, boolean bottomToo
         documentView.setBottomToolbarEnabled(bottomToolbarEnabled);
     }
 
+    @ReactProp(name = "hideToolbarsOnTap")
+    public void setHideToolbarsOnTap(DocumentView documentView, boolean hideToolbarsOnTap) {
+        documentView.setHideToolbarsOnTap(hideToolbarsOnTap);
+    }
+
     @ReactProp(name = "pageIndicatorEnabled")
     public void setPageIndicatorEnabled(DocumentView documentView, boolean pageIndicatorEnabled) {
         documentView.setPageIndicatorEnabled(pageIndicatorEnabled);

android/src/main/java/com/pdftron/reactnative/views/DocumentView.java

@@ -258,6 +258,10 @@ public void setPageIndicatorEnabled(boolean pageIndicatorEnabled) {
         mBuilder = mBuilder.showPageNumberIndicator(pageIndicatorEnabled);
     }
 
+    public void setHideToolbarsOnTap(boolean hideToolbarsOnTap) {
+        mBuilder = mBuilder.permanentTopToolbar(!hideToolbarsOnTap);
+    }
+
     public void setReadOnly(boolean readOnly) {
         mBuilder = mBuilder.documentEditingEnabled(!readOnly);
     }

ios/RNTPTDocumentView.h

@@ -200,6 +200,7 @@ static NSString * const PTFormFieldValueKey = @"fieldValue";
 @property (nonatomic, assign) BOOL topToolbarEnabled;
 @property (nonatomic, assign) BOOL bottomToolbarEnabled;
 @property (nonatomic, assign) BOOL pageIndicatorEnabled;
+@property (nonatomic, assign) BOOL hideToolbarsOnTap;
 @property (nonatomic, assign) BOOL pageIndicatorShowsOnPageChange;
 @property (nonatomic, assign) BOOL pageIndicatorShowsWithControls;
 @property (nonatomic, assign) BOOL autoSaveEnabled;

ios/RNTPTDocumentView.m

@@ -46,6 +46,7 @@ - (void)RNTPTDocumentView_commonInit
 {
     _topToolbarEnabled = YES;
     _bottomToolbarEnabled = YES;
+    _hideToolbarsOnTap = YES;
 
     _pageIndicatorEnabled = YES;
     _pageIndicatorShowsOnPageChange = YES;
@@ -1119,6 +1120,13 @@ -(void)setBottomToolbarEnabled:(BOOL)bottomToolbarEnabled
     [self applyViewerSettings];
 }
 
+- (void)setHideToolbarsOnTap:(BOOL)hideToolbarsOnTap
+{
+    _hideToolbarsOnTap = hideToolbarsOnTap;
+    
+    [self applyViewerSettings];
+}
+
 #pragma mark - Page indicator
 
 -(void)setPageIndicatorEnabled:(BOOL)pageIndicatorEnabled
@@ -1211,13 +1219,21 @@ - (void)applyViewerSettings
         self.documentViewController.hidesControlsOnTap = YES;
         self.documentViewController.controlsHidden = NO;
     }
-    const BOOL translucent = self.documentViewController.hidesControlsOnTap;
+    if (self.topToolbarEnabled) {
+        self.documentViewController.controlsHidden = NO;
+    } else {
+        self.documentViewController.controlsHidden = YES;
+    }
+    const BOOL translucent = self.topToolbarEnabled;
     self.documentViewController.thumbnailSliderController.toolbar.translucent = translucent;
     self.documentViewController.navigationController.navigationBar.translucent = translucent;
 
     // Bottom toolbar.
     self.documentViewController.bottomToolbarEnabled = self.bottomToolbarEnabled;
 
+    self.documentViewController.hidesControlsOnTap = self.hideToolbarsOnTap;
+    self.documentViewController.pageFitsBetweenBars = !self.hideToolbarsOnTap;
+    
     // Page indicator.
     self.documentViewController.pageIndicatorEnabled = self.pageIndicatorEnabled;
 

ios/RNTPTDocumentViewManager.m

@@ -115,6 +115,13 @@ - (instancetype)init
     }
 }
 
+RCT_CUSTOM_VIEW_PROPERTY(hideToolbarsOnTap, BOOL, RNTPTDocumentView)
+{
+    if (json) {
+        view.hideToolbarsOnTap = [RCTConvert BOOL:json];
+    }
+}
+
 RCT_CUSTOM_VIEW_PROPERTY(pageIndicatorEnabled, BOOL, RNTPTDocumentView)
 {
     if (json) {

src/DocumentView/DocumentView.js

@@ -39,6 +39,7 @@ export default class DocumentView extends PureComponent {
     onBehaviorActivated: PropTypes.func,
     topToolbarEnabled: PropTypes.bool,
     bottomToolbarEnabled: PropTypes.bool,
+    hideToolbarsOnTap: PropTypes.bool,
     pageIndicatorEnabled: PropTypes.bool,
     onAnnotationsSelected: PropTypes.func,
     onAnnotationChanged: PropTypes.func,