From 148dd3ddc572e905e6d318ab6c8ada4f1b7c9204 Mon Sep 17 00:00:00 2001 From: Ernst Hellbar Date: Fri, 22 Aug 2025 11:10:46 +0200 Subject: [PATCH 1/2] GLO VTX: move fitting outside of the histogram filling loop --- Modules/GLO/src/VertexingQcTask.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Modules/GLO/src/VertexingQcTask.cxx b/Modules/GLO/src/VertexingQcTask.cxx index 00f9880e8c..bfc1fcc353 100644 --- a/Modules/GLO/src/VertexingQcTask.cxx +++ b/Modules/GLO/src/VertexingQcTask.cxx @@ -209,9 +209,7 @@ void VertexingQcTask::monitorData(o2::framework::ProcessingContext& ctx) auto timeUnc = pvertices[i].getTimeStamp().getTimeStampError(); ILOG(Debug, Support) << "x = " << x << ", y = " << y << ", z = " << z << ", nContributors = " << nContr << ", timeUnc = " << timeUnc << ENDM; mX->Fill(x); - mX->Fit("fX", "Q", "", mX->GetMean() - mX->GetRMS(), mX->GetMean() + mX->GetRMS()); mY->Fill(y); - mY->Fit("fY", "Q", "", mY->GetMean() - mY->GetRMS(), mY->GetMean() + mY->GetRMS()); mZ->Fill(z); mNContributors->Fill(nContr); mTimeUncVsNContrib->Fill(nContr, timeUnc); @@ -233,6 +231,8 @@ void VertexingQcTask::monitorData(o2::framework::ProcessingContext& ctx) mVtxPullsZVsMult->Fill(mult, (vtMC[2] - pvertices[i].getZ()) / std::sqrt(pvertices[i].getSigmaZ2())); } } + mX->Fit("fX", "Q", "", mX->GetMean() - mX->GetRMS(), mX->GetMean() + mX->GetRMS()); + mY->Fit("fY", "Q", "", mY->GetMean() - mY->GetRMS(), mY->GetMean() + mY->GetRMS()); } void VertexingQcTask::endOfCycle() From 94b28eee906b9431dfe611e4b98bb1e10ee9d684 Mon Sep 17 00:00:00 2001 From: Ernst Hellbar Date: Fri, 22 Aug 2025 11:58:37 +0200 Subject: [PATCH 2/2] TPC PID: attempt to avoid occasional TMinuit errors --- Modules/TPC/src/PID.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/TPC/src/PID.cxx b/Modules/TPC/src/PID.cxx index 03d9951bb3..e4920a2496 100644 --- a/Modules/TPC/src/PID.cxx +++ b/Modules/TPC/src/PID.cxx @@ -114,7 +114,7 @@ void PID::endOfCycle() fitFunc.SetParameter(5, 10); // Sigma of the second Gaussian // Fit the histogram with the fitting function - hist->Fit(&fitFunc, "QRN"); + hist->Fit(&fitFunc, "QRNM"); const TString binLabels[8] = { "Amplitude Pi", "Mean Pi", "Sigma Pi", "Amplitude El", "Mean El", "Sigma El", "Separation Power", "chiSquare/ndf" };