From b2f76bcfbc7ac793963614fb2c864848ccf62d25 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+ktf@users.noreply.github.com> Date: Tue, 28 Jan 2025 08:57:22 +0100 Subject: [PATCH] Drop tautological comparison A pointer to a reference cannot be nullptr. If it is, whatever created the reference in the first place has already crashed. If this is to be protected, one should return the pointer and check that. --- Modules/MUON/MCH/src/GlobalHistogram.cxx | 9 --------- 1 file changed, 9 deletions(-) diff --git a/Modules/MUON/MCH/src/GlobalHistogram.cxx b/Modules/MUON/MCH/src/GlobalHistogram.cxx index 5eab2e14a2..084a4a8a60 100644 --- a/Modules/MUON/MCH/src/GlobalHistogram.cxx +++ b/Modules/MUON/MCH/src/GlobalHistogram.cxx @@ -669,9 +669,6 @@ void GlobalHistogram::getDeCenterST12(int de, float& xB0, float& yB0, float& xNB } const o2::mch::mapping::Segmentation& segment = o2::mch::mapping::segmentation(de); - if ((&segment) == nullptr) { - return; - } const o2::mch::mapping::CathodeSegmentation& csegment = segment.bending(); o2::mch::contour::Contour envelop = o2::mch::mapping::getEnvelop(csegment); std::vector> vertices = envelop.getVertices(); @@ -742,9 +739,6 @@ void GlobalHistogram::getDeCenterST3(int de, float& xB0, float& yB0, float& xNB0 } const o2::mch::mapping::Segmentation& segment = o2::mch::mapping::segmentation(de); - if ((&segment) == nullptr) { - return; - } const o2::mch::mapping::CathodeSegmentation& csegment = segment.bending(); o2::mch::contour::Contour envelop = o2::mch::mapping::getEnvelop(csegment); std::vector> vertices = envelop.getVertices(); @@ -851,9 +845,6 @@ void GlobalHistogram::getDeCenterST4(int de, float& xB0, float& yB0, float& xNB0 } const o2::mch::mapping::Segmentation& segment = o2::mch::mapping::segmentation(de); - if ((&segment) == nullptr) { - return; - } const o2::mch::mapping::CathodeSegmentation& csegment = segment.bending(); o2::mch::contour::Contour envelop = o2::mch::mapping::getEnvelop(csegment); std::vector> vertices = envelop.getVertices();