From 956e936a460274add3793cbc443b602e27f367fd Mon Sep 17 00:00:00 2001 From: Isakov Artem Date: Mon, 13 Jan 2025 09:09:55 +0100 Subject: [PATCH 1/3] Increased ranges and type of the cluster size histograms for Layer --- Modules/ITS/include/ITS/ITSClusterTask.h | 6 +++--- Modules/ITS/src/ITSClusterTask.cxx | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Modules/ITS/include/ITS/ITSClusterTask.h b/Modules/ITS/include/ITS/ITSClusterTask.h index 6122176fe4..f48ca10b1e 100644 --- a/Modules/ITS/include/ITS/ITSClusterTask.h +++ b/Modules/ITS/include/ITS/ITSClusterTask.h @@ -93,9 +93,9 @@ class ITSClusterTask : public TaskInterface std::shared_ptr hAverageClusterSizeSummaryOB[NLayer]; // Layer summary - TH1D* hClusterSizeLayerSummary[NLayer] = { nullptr }; - TH1D* hClusterTopologyLayerSummary[NLayer] = { nullptr }; - TH1D* hGroupedClusterSizeLayerSummary[NLayer] = { nullptr }; + TH1L* hClusterSizeLayerSummary[NLayer] = { nullptr }; + TH1L* hClusterTopologyLayerSummary[NLayer] = { nullptr }; + TH1L* hGroupedClusterSizeLayerSummary[NLayer] = { nullptr }; // Anomalies plots TH2D* hLongClustersPerChip[3] = { nullptr }; diff --git a/Modules/ITS/src/ITSClusterTask.cxx b/Modules/ITS/src/ITSClusterTask.cxx index 4825f9b4cc..2c35e7d729 100644 --- a/Modules/ITS/src/ITSClusterTask.cxx +++ b/Modules/ITS/src/ITSClusterTask.cxx @@ -472,19 +472,19 @@ void ITSClusterTask::createAllHistos() hMultPerChipWhenLongClusters[iLayer]->SetStats(0); } - hClusterSizeLayerSummary[iLayer] = new TH1D(Form("Layer%d/AverageClusterSizeSummary", iLayer), Form("Layer%dAverageClusterSizeSummary", iLayer), 100, 0, 100); + hClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageClusterSizeSummary", iLayer), Form("Layer%dAverageClusterSizeSummary", iLayer), 1000, 0, 1000); hClusterSizeLayerSummary[iLayer]->SetTitle(Form("Cluster size summary for Layer %d", iLayer)); addObject(hClusterSizeLayerSummary[iLayer]); formatAxes(hClusterSizeLayerSummary[iLayer], "Cluster Size (pixels)", "counts", 1, 1.10); hClusterSizeLayerSummary[iLayer]->SetStats(0); - hGroupedClusterSizeLayerSummary[iLayer] = new TH1D(Form("Layer%d/AverageGroupedClusterSizeSummary", iLayer), Form("Layer%dAverageGroupedClusterSizeSummary", iLayer), 100, 0, 100); + hGroupedClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageGroupedClusterSizeSummary", iLayer), Form("Layer%dAverageGroupedClusterSizeSummary", iLayer), 1000, 0, 1000); hGroupedClusterSizeLayerSummary[iLayer]->SetTitle(Form("Cluster size summary for Layer %d", iLayer)); addObject(hGroupedClusterSizeLayerSummary[iLayer]); formatAxes(hGroupedClusterSizeLayerSummary[iLayer], "Grouped Cluster Size (pixels)", "counts", 1, 1.10); hGroupedClusterSizeLayerSummary[iLayer]->SetStats(0); - hClusterTopologyLayerSummary[iLayer] = new TH1D(Form("Layer%d/ClusterTopologySummary", iLayer), Form("Layer%dClusterTopologySummary", iLayer), 300, 0, 300); + hClusterTopologyLayerSummary[iLayer] = new TH1L(Form("Layer%d/ClusterTopologySummary", iLayer), Form("Layer%dClusterTopologySummary", iLayer), 300, 0, 300); hClusterTopologyLayerSummary[iLayer]->SetTitle(Form("Cluster topology summary for Layer %d", iLayer)); addObject(hClusterTopologyLayerSummary[iLayer]); formatAxes(hClusterTopologyLayerSummary[iLayer], "Cluster Topology (ID)", "counts", 1, 1.10); From 7ac458526a8f25c314d43a1891e00e4f691d02d7 Mon Sep 17 00:00:00 2001 From: Isakov Artem Date: Mon, 20 Jan 2025 16:14:38 +0100 Subject: [PATCH 2/3] Further increase of ranges --- Modules/ITS/src/ITSClusterTask.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Modules/ITS/src/ITSClusterTask.cxx b/Modules/ITS/src/ITSClusterTask.cxx index 2c35e7d729..2df6ad430f 100644 --- a/Modules/ITS/src/ITSClusterTask.cxx +++ b/Modules/ITS/src/ITSClusterTask.cxx @@ -472,13 +472,13 @@ void ITSClusterTask::createAllHistos() hMultPerChipWhenLongClusters[iLayer]->SetStats(0); } - hClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageClusterSizeSummary", iLayer), Form("Layer%dAverageClusterSizeSummary", iLayer), 1000, 0, 1000); + hClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageClusterSizeSummary", iLayer), Form("Layer%dAverageClusterSizeSummary", iLayer), 128*128, 0, 128*128); hClusterSizeLayerSummary[iLayer]->SetTitle(Form("Cluster size summary for Layer %d", iLayer)); addObject(hClusterSizeLayerSummary[iLayer]); formatAxes(hClusterSizeLayerSummary[iLayer], "Cluster Size (pixels)", "counts", 1, 1.10); hClusterSizeLayerSummary[iLayer]->SetStats(0); - hGroupedClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageGroupedClusterSizeSummary", iLayer), Form("Layer%dAverageGroupedClusterSizeSummary", iLayer), 1000, 0, 1000); + hGroupedClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageGroupedClusterSizeSummary", iLayer), Form("Layer%dAverageGroupedClusterSizeSummary", iLayer), 128*128, 0, 128*128); hGroupedClusterSizeLayerSummary[iLayer]->SetTitle(Form("Cluster size summary for Layer %d", iLayer)); addObject(hGroupedClusterSizeLayerSummary[iLayer]); formatAxes(hGroupedClusterSizeLayerSummary[iLayer], "Grouped Cluster Size (pixels)", "counts", 1, 1.10); From 30c69e1d58ae3eb58dfced8a3e97e0652f1b3875 Mon Sep 17 00:00:00 2001 From: Isakov Artem Date: Mon, 20 Jan 2025 16:19:15 +0100 Subject: [PATCH 3/3] clang --- Modules/ITS/src/ITSClusterTask.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Modules/ITS/src/ITSClusterTask.cxx b/Modules/ITS/src/ITSClusterTask.cxx index 2df6ad430f..95748a528f 100644 --- a/Modules/ITS/src/ITSClusterTask.cxx +++ b/Modules/ITS/src/ITSClusterTask.cxx @@ -472,13 +472,13 @@ void ITSClusterTask::createAllHistos() hMultPerChipWhenLongClusters[iLayer]->SetStats(0); } - hClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageClusterSizeSummary", iLayer), Form("Layer%dAverageClusterSizeSummary", iLayer), 128*128, 0, 128*128); + hClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageClusterSizeSummary", iLayer), Form("Layer%dAverageClusterSizeSummary", iLayer), 128 * 128, 0, 128 * 128); hClusterSizeLayerSummary[iLayer]->SetTitle(Form("Cluster size summary for Layer %d", iLayer)); addObject(hClusterSizeLayerSummary[iLayer]); formatAxes(hClusterSizeLayerSummary[iLayer], "Cluster Size (pixels)", "counts", 1, 1.10); hClusterSizeLayerSummary[iLayer]->SetStats(0); - hGroupedClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageGroupedClusterSizeSummary", iLayer), Form("Layer%dAverageGroupedClusterSizeSummary", iLayer), 128*128, 0, 128*128); + hGroupedClusterSizeLayerSummary[iLayer] = new TH1L(Form("Layer%d/AverageGroupedClusterSizeSummary", iLayer), Form("Layer%dAverageGroupedClusterSizeSummary", iLayer), 128 * 128, 0, 128 * 128); hGroupedClusterSizeLayerSummary[iLayer]->SetTitle(Form("Cluster size summary for Layer %d", iLayer)); addObject(hGroupedClusterSizeLayerSummary[iLayer]); formatAxes(hGroupedClusterSizeLayerSummary[iLayer], "Grouped Cluster Size (pixels)", "counts", 1, 1.10);