From ab79ae5fd7d63e3c4981fa77592db18d337e9842 Mon Sep 17 00:00:00 2001 From: Piotr Konopka Date: Tue, 5 Aug 2025 11:04:31 +0200 Subject: [PATCH] No need to force ERROR when GO_ERROR succeeded Probably due to a mostly harmless mistake, we would force an environment into ERROR state even when not needed, after a successful GO_ERROR. If very unlucky, this could cause some conflicts with following transitions towards environment destruction. This affects only GO_ERROR due to ODC going to ERROR, other cases are fine. I did not see this issue cause any troubles, I just accidentally stumbled upon it. --- core/environment/manager.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/environment/manager.go b/core/environment/manager.go index 0f239b73..5379d874 100644 --- a/core/environment/manager.go +++ b/core/environment/manager.go @@ -997,8 +997,8 @@ func (envs *Manager) handleIntegratedServiceEvent(evt event.IntegratedServiceEve WithField("partition", envId.String()). WithError(err). Error("environment GO_ERROR transition failed after ODC_PARTITION_STATE_CHANGE ERROR event") + env.setState("ERROR") } - env.setState("ERROR") } }() }