From 188c7b3a506f38ae61ffac5022a3bfc9cd193003 Mon Sep 17 00:00:00 2001 From: Piotr Konopka Date: Tue, 13 May 2025 12:14:34 +0200 Subject: [PATCH 1/2] demote MesosCommand send error log This log cannot be understood by an operator on its own. typically, there is another error log just after, which includes this message, but also gives some context: ``` transition 'START_ACTIVITY' failed, transitioning into ERROR. error="transition canceled with error: START could not complete for critical tasks, errors: task 'source /etc/profile.d/o2.sh && export DPL_RAWPROXY_OVERRIDE_ORBITRESET=1718863780392 && o2-qc --config apricot://alio2-cr1-hv-aliecs.cern.ch:32188/o2/components/qc/ANY/any/tof-full-epn-qcmn --remote --shm-metadata-msg-size 100000 -b | o2-qc' on alio2-cr1-qc03 (id 2uWFxUQq3ku) failed with error: MesosCommand_Transition timed out for task 2uWFxUQq3ku" ``` i think it's fine to move it to Devel --- core/controlcommands/commandqueue.go | 1 + 1 file changed, 1 insertion(+) diff --git a/core/controlcommands/commandqueue.go b/core/controlcommands/commandqueue.go index 0c769dec..376be03d 100644 --- a/core/controlcommands/commandqueue.go +++ b/core/controlcommands/commandqueue.go @@ -163,6 +163,7 @@ func (m *CommandQueue) commit(command MesosCommand) (response MesosCommandRespon res, err := m.servent.RunCommand(singleCommand, receiver) if err != nil { log.WithField("partition", command.GetEnvironmentId().String()). + WithField(infologger.Level, infologger.IL_Devel). WithError(err). Warning("MesosCommand send error") From 1f6aa955926ea0acc7315323e12b8ee9b9a7887f Mon Sep 17 00:00:00 2001 From: Piotr Konopka Date: Tue, 13 May 2025 14:44:24 +0200 Subject: [PATCH 2/2] missing import --- core/controlcommands/commandqueue.go | 1 + 1 file changed, 1 insertion(+) diff --git a/core/controlcommands/commandqueue.go b/core/controlcommands/commandqueue.go index 376be03d..66af7c65 100644 --- a/core/controlcommands/commandqueue.go +++ b/core/controlcommands/commandqueue.go @@ -27,6 +27,7 @@ package controlcommands import ( "errors" "fmt" + "github.com/AliceO2Group/Control/common/logger/infologger" "strings" "sync" "time"