Skip to content

Conversation

@kwin
Copy link
Contributor

@kwin kwin commented Feb 28, 2024

This closes #3276

@kwin kwin requested a review from davidjgonzalez February 28, 2024 11:58
@codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 220 lines in your changes are missing coverage. Please review.

Project coverage is 1.76%. Comparing base (b0a4f23) to head (7a8bbfe).
Report is 5 commits behind head on master.

❗ Current head 7a8bbfe differs from pull request most recent head c34905d. Consider uploading reports for the commit c34905d to get more accurate results

Files Patch % Lines
...mmons/http/impl/OsgiManagedJavaHttpClientImpl.java 0.00% 66 Missing ⚠️
.../commons/http/impl/ProxyConfigurationSelector.java 0.00% 58 Missing ⚠️
...dobe/acs/commons/http/impl/AemKeyStoreFactory.java 0.00% 47 Missing ⚠️
...adobe/acs/commons/http/impl/TrustManagerUtils.java 0.00% 19 Missing ⚠️
...m/adobe/acs/commons/http/impl/KeyManagerUtils.java 0.00% 14 Missing ⚠️
...adobe/acs/commons/http/impl/ProxySelectorImpl.java 0.00% 9 Missing ⚠️
.../acs/commons/http/impl/ProxyAuthenticatorImpl.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #3280       +/-   ##
============================================
- Coverage     55.45%   1.76%   -53.69%     
+ Complexity     5506     100     -5406     
============================================
  Files           721     728        +7     
  Lines         29534   29753      +219     
  Branches       3840    3869       +29     
============================================
- Hits          16378     526    -15852     
- Misses        11630   29189    +17559     
+ Partials       1526      38     -1488     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kwin kwin force-pushed the feature/java-http-client branch 2 times, most recently from c56ac13 to 7a8bbfe Compare February 29, 2024 14:45
@kwin kwin force-pushed the feature/java-http-client branch from 7a8bbfe to d211b53 Compare March 2, 2024 10:35
@kwin
Copy link
Contributor Author

kwin commented Sep 13, 2024

TODO: Add some mock-server tests (https://www.mock-server.com/mock_server/HTTPS_TLS.html)

Update: as mock-server is no longer maintained instead https://wiremock.org/ can be used for tests.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OSGi support for Java HTTP Client

3 participants