setup SwiftLint and fixed all swiftlint errors and waning

Author: saroar

.swiftlint.yml

@@ -0,0 +1,54 @@
+disabled_rules:
+  - vertical_parameter_alignment_on_call
+  - weak_delegate
+  - vertical_parameter_alignment
+  - closure_parameter_position
+  - todo	
+  - multiple_closures_with_trailing_closure
+opt_in_rules:
+  - empty_count
+  - explicit_init
+  - closure_spacing
+  - overridden_super_call
+  - redundant_nil_coalescing
+  - private_outlet
+  - nimble_operator
+  - operator_usage_whitespace
+  - closure_end_indentation
+  - first_where
+  - prohibited_super_call
+  - fatal_error_message
+  - unneeded_parentheses_in_closure_argument
+  - pattern_matching_keywords
+  - array_init
+  - literal_expression_end_indentation
+  - joined_default_parameter
+  - contains_over_first_not_nil
+  - override_in_extension
+  - private_action
+  - quick_discouraged_call
+  - quick_discouraged_focused_test
+  - quick_discouraged_pending_test
+  - single_test_class
+  - sorted_first_last
+
+warning_threshold: 1
+
+line_length: 120
+
+type_body_length:
+  - 300 # warning
+  - 300 # error
+
+file_length:
+  warning: 400 # warning
+  error: 400 # error
+
+identifier_name:
+  min_length:
+    error: 2
+  max_length:
+    error: 50
+  excluded:
+    - id
+    - _id

Addame.xcodeproj/project.pbxproj

@@ -105,6 +105,7 @@
 				C3E50C98261B5DFA00285977 /* Sources */,
 				C3E50C99261B5DFA00285977 /* Frameworks */,
 				C3E50C9A261B5DFA00285977 /* Resources */,
+				C3F9CB0A2678E4540007F6B9 /* SwiftLint */,
 			);
 			buildRules = (
 			);
@@ -162,6 +163,27 @@
 		};
 /* End PBXResourcesBuildPhase section */
 
+/* Begin PBXShellScriptBuildPhase section */
+		C3F9CB0A2678E4540007F6B9 /* SwiftLint */ = {
+			isa = PBXShellScriptBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+			);
+			inputFileListPaths = (
+			);
+			inputPaths = (
+			);
+			name = SwiftLint;
+			outputFileListPaths = (
+			);
+			outputPaths = (
+			);
+			runOnlyForDeploymentPostprocessing = 0;
+			shellPath = /bin/sh;
+			shellScript = "if which swiftlint >/dev/null; then\n  swiftlint --fix --config \".swiftlint.yml\" && swiftlint\nelse\n  echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";
+		};
+/* End PBXShellScriptBuildPhase section */
+
 /* Begin PBXSourcesBuildPhase section */
 		C3E50C98261B5DFA00285977 /* Sources */ = {
 			isa = PBXSourcesBuildPhase;

Addame.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -24,7 +24,7 @@ let package = Package(
     .library(name: "RemoteNotificationsClient", targets: ["RemoteNotificationsClient"]),
     .library(name: "UIApplicationClient", targets: ["UIApplicationClient"]),
     .library(name: "UserDefaultsClient", targets: ["UserDefaultsClient"]),
-    
+
     .library(name: "AttachmentClient", targets: ["AttachmentClient"]),
     .library(name: "AttachmentClientLive", targets: ["AttachmentClientLive"]),
     .library(name: "AuthClient", targets: ["AuthClient"]),
@@ -44,7 +44,7 @@ let package = Package(
     .library(name: "UserClientLive", targets: ["UserClientLive"]),
     .library(name: "WebsocketClient", targets: ["WebsocketClient"]),
     .library(name: "WebsocketClientLive", targets: ["WebsocketClientLive"]),
-    
+
     // Views
     .library(name: "AuthenticationView", targets: ["AuthenticationView"]),
     .library(name: "ChatView", targets: ["ChatView"]),
@@ -55,7 +55,7 @@ let package = Package(
     .library(name: "ProfileView", targets: ["ProfileView"]),
     .library(name: "TabsView", targets: ["TabsView"]),
     .library(name: "SettingsView", targets: ["SettingsView"]),
-    
+
     // Helpers
     .library(name: "NotificationHelpers", targets: ["NotificationHelpers"]),
     .library(name: "SwiftUIHelpers", targets: ["SwiftUIHelpers"]),
@@ -66,11 +66,11 @@ let package = Package(
   dependencies: [
     .package(name: "AWSSDKSwift", url: "https://github.com/swift-aws/aws-sdk-swift.git", from: "4.9.0"),
     .package(url: "https://github.com/marmelroy/PhoneNumberKit", .upToNextMajor(from: "3.3.3")),
-    .package(url: "https://github.com/pointfreeco/swift-composable-architecture.git",from: "0.17.0"),
+    .package(url: "https://github.com/pointfreeco/swift-composable-architecture.git", from: "0.17.0"),
     .package(url: "https://github.com/pointfreeco/composable-core-location", from: "0.1.0"),
     .package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay", from: "0.1.0"),
     .package(url: "https://github.com/AddaMeSPB/CombineContacts.git", from: "1.0.0"),
-    .package(url: "https://github.com/AddaMeSPB/HttpRequest.git", from: "1.0.1"),
+    .package(url: "https://github.com/AddaMeSPB/HttpRequest.git", from: "1.0.1")
   ],
 
   targets: [
@@ -81,9 +81,9 @@ let package = Package(
         "UserNotificationClient", "RemoteNotificationsClient", "NotificationHelpers",
         "AuthClient", "AuthClientLive", "AttachmentClient", "ChatClient", "ContactClient",
         "ConversationClient", "EventClient", "UserClient", "WebsocketClient",
-        
+
         "EventView", "ConversationsView", "ProfileView", "TabsView", "AuthenticationView",
-        "SettingsView",
+        "SettingsView"
       ]),
 
     .testTarget(
@@ -118,35 +118,35 @@ let package = Package(
       dependencies: [
         .product(name: "ComposableArchitecture", package: "swift-composable-architecture")
       ]),
-    
+
     .target(
       name: "UserNotificationClient",
       dependencies: [
         .product(name: "ComposableArchitecture", package: "swift-composable-architecture")
       ]),
-    
+
     .target(
       name: "UIApplicationClient",
       dependencies: [
         .product(name: "ComposableArchitecture", package: "swift-composable-architecture"),
-        .product(name: "XCTestDynamicOverlay", package: "xctest-dynamic-overlay"),
+        .product(name: "XCTestDynamicOverlay", package: "xctest-dynamic-overlay")
       ]
     ),
 
     .target(
       name: "UserDefaultsClient",
       dependencies: [
         .product(name: "ComposableArchitecture", package: "swift-composable-architecture"),
-        .product(name: "XCTestDynamicOverlay", package: "xctest-dynamic-overlay"),
+        .product(name: "XCTestDynamicOverlay", package: "xctest-dynamic-overlay")
       ]
     ),
-    
+
     .target(
       name: "CoreDataClient",
       dependencies: [
-        "CoreDataStore", "ContactClient", "ContactClientLive", "SharedModels",
+        "CoreDataStore", "ContactClient", "ContactClientLive", "SharedModels"
       ]),
-    
+
     .target(
       name: "AttachmentClient",
       dependencies: [
@@ -204,24 +204,23 @@ let package = Package(
       name: "UserClient",
       dependencies: ["SharedModels", "HttpRequest", "KeychainService", "InfoPlist"]),
     .target(name: "UserClientLive", dependencies: ["UserClient"]),
-    
+
     .target(
       name: "WebsocketClient",
       dependencies: ["FoundationExtension", "HttpRequest", "SharedModels", "InfoPlist", "KeychainService"]),
     .target(
       name: "WebsocketClientLive",
       dependencies: ["WebsocketClient"]),
-    
+
     // Views
     .target(
       name: "AuthenticationView",
       dependencies: [
         .product(name: "ComposableArchitecture", package: "swift-composable-architecture"),
         "PhoneNumberKit", "SharedModels", "AuthClient", "KeychainService",
-        "HttpRequest", "AuthClientLive",
+        "HttpRequest", "AuthClientLive"
       ]),
 
-
     .target(
       name: "TabsView",
       dependencies: [
@@ -244,7 +243,7 @@ let package = Package(
         "WebsocketClientLive"
       ]
     ),
-    
+
     .target(
       name: "ConversationsView",
       dependencies: [
@@ -257,7 +256,7 @@ let package = Package(
         "ContactClient", "ContactClientLive", "ContactsView", "CoreDataClient"
       ]
     ),
-    
+
     .target(
       name: "ContactsView",
       dependencies: [
@@ -268,7 +267,7 @@ let package = Package(
         "CoreDataStore", "CoreDataClient",
         "ChatView", "ComposableArchitectureHelpers"
       ]),
-    
+
     .target(
       name: "EventView",
       dependencies: [
@@ -278,18 +277,18 @@ let package = Package(
         "PathMonitorClient", "WebsocketClient", "ConversationClient",
         "SwiftUIExtension", "FoundationExtension", "AsyncImageLoder",
         "HttpRequest", "KeychainService", "ChatClient",
-        "PathMonitorClientLive", "EventClientLive", "ComposableArchitectureHelpers",
+        "PathMonitorClientLive", "EventClientLive", "ComposableArchitectureHelpers"
       ]
     ),
-    
+
     .target(
       name: "EventForm",
       dependencies: [
         .product(name: "ComposableArchitecture", package: "swift-composable-architecture"),
-        "SharedModels", "EventClient", "InfoPlist",
+        "SharedModels", "EventClient", "InfoPlist"
       ]
     ),
-    
+
     .target(
         name: "ProfileView",
         dependencies: [
@@ -299,35 +298,35 @@ let package = Package(
           "SwiftUIExtension", "FoundationExtension", "AsyncImageLoder",
           "HttpRequest", "KeychainService", "AuthenticationView",
           "AttachmentClientLive", "AuthClientLive", "UserClientLive",
-          "EventClientLive",
+          "EventClientLive"
         ]
     ),
-    
+
     .target(
       name: "SettingsView",
       dependencies: [
         "UIApplicationClient", "UserDefaultsClient",
         .product(name: "ComposableArchitecture", package: "swift-composable-architecture"),
-        .product(name: "XCTestDynamicOverlay", package: "xctest-dynamic-overlay"),
+        .product(name: "XCTestDynamicOverlay", package: "xctest-dynamic-overlay")
       ]
     ),
-    
+
     // Helpers
     .target(
       name: "NotificationHelpers",
       dependencies: [
         "UserNotificationClient", "RemoteNotificationsClient",
-        .product(name: "ComposableArchitecture", package: "swift-composable-architecture"),
+        .product(name: "ComposableArchitecture", package: "swift-composable-architecture")
       ]
     ),
-    
+
     .target(name: "SwiftUIHelpers"),
     .target(name: "CombineHelpers"),
     .target(
       name: "ComposableArchitectureHelpers",
       dependencies: [
         .product(name: "ComposableArchitecture", package: "swift-composable-architecture")
       ]
-    ),
+    )
   ]
 )

Addame/Addame/Package.swift

@@ -24,7 +24,7 @@ struct AppDelegateEnvironment {
   var userNotifications: UserNotificationClient
   var remoteNotifications: RemoteNotificationsClient
   var authClient: AuthClient
-  
+
 //  #if DEBUG
 //    static let failing = Self(
 //      backgroundQueue: .failing("backgroundQueue"),
@@ -105,6 +105,6 @@ let appDelegateReducer = Reducer<
         //     can set the user interface style.
         .subscribe(on: environment.mainQueue)
         .fireAndForget()
-    
+
   }
 }

Addame/Addame/Sources/AppFeature/AppDelegate.swift

@@ -16,17 +16,17 @@ import AuthClient
 import AuthClientLive
 
 public struct AppView: View {
-  
+
   public init() {}
-  
+
   @AppStorage("isAuthorized")
   public var isAuthorized: Bool = false
-  
+
   static let tabsEnv = TabsEnvironment(
     backgroundQueue: .main,
     mainQueue: .main
   )
-  
+
   static let tabsState = TabsState(
     selectedTab: .event,
     event: EventsState(),