Skip to content

Commit edaaadf

Browse files
committed
Minor changes in CMakeLists.txt
1 parent 2dddea8 commit edaaadf

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ else()
1717
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DHAVE_OPENMP ${OpenMP_C_FLAGS}")
1818
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DHAVE_OPENMP ${OpenMP_CXX_FLAGS}")
1919
endif()
20-
include_directories(${HDF5_INCLUDE_DIR} ${TIFF_INCLUDE_DIR} ${CMAKE_CURRENT_SOURCE_DIR})
20+
include_directories(${HDF5_INCLUDE_DIR} ${TIFF_INCLUDE_DIR} )
2121
add_subdirectory("external/c-blosc")
2222
set_target_properties(blosc_shared PROPERTIES RUNTIME_OUTPUT_DIRECTORY_DEBUG ${PROJECT_BINARY_DIR})
2323
set_target_properties(blosc_shared PROPERTIES RUNTIME_OUTPUT_DIRECTORY_RELEASE ${PROJECT_BINARY_DIR})
@@ -83,11 +83,11 @@ if(APR_BUILD_JAVA_WRAPPERS)
8383
find_package(SWIG 3.0 REQUIRED)
8484
find_package(JNI REQUIRED)
8585
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/src/natives")
86-
include_directories(${JNI_INCLUDE_DIRS})
87-
INCLUDE(${SWIG_USE_FILE})
86+
include_directories(${JNI_INCLUDE_DIRS} ${CMAKE_CURRENT_SOURCE_DIR})
87+
include(${SWIG_USE_FILE})
8888
set(CMAKE_SWIG_OUTDIR "${CMAKE_CURRENT_SOURCE_DIR}/src/main/java/de/mpicbg/mosaic/apr")
8989
set(CMAKE_SWIG_FLAGS -package de.mpicbg.mosaic.apr -Wall)
90-
SET_SOURCE_FILES_PROPERTIES(libapr.i PROPERTIES CPLUSPLUS ON)
91-
SWIG_ADD_LIBRARY(apr LANGUAGE java SOURCES libapr.i ${SOURCE_FILES})
92-
SWIG_LINK_LIBRARIES(apr ${HDF5_LIBRARIES} blosc_static ${TIFF_LIBRARIES})
90+
set_source_files_properties(libapr.i PROPERTIES CPLUSPLUS ON)
91+
swig_add_library(apr LANGUAGE java SOURCES libapr.i ${SOURCE_FILES})
92+
swig_link_libraries(apr ${HDF5_LIBRARIES} blosc_static ${TIFF_LIBRARIES})
9393
endif(APR_BUILD_JAVA_WRAPPERS)

src/algorithm/APRConverter.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,7 @@ void APRConverter<ImageType>::init_apr(APR<ImageType>& aAPR,MeshData<T>& input_i
353353
int min_dim = std::min(std::min(aAPR.apr_access.org_dims[1], aAPR.apr_access.org_dims[0]), aAPR.apr_access.org_dims[2]);
354354

355355
int levelMax = ceil(std::log2(max_dim));
356+
// TODO: why minimum level is forced here to be 2?
356357
int levelMin = std::max( (int)(levelMax - floor(std::log2(min_dim))), 2);
357358

358359
aAPR.apr_access.level_min = levelMin;
@@ -561,7 +562,6 @@ void APRConverter<ImageType>::auto_parameters(const MeshData<T>& input_img){
561562
// Detecting background subtracted images, or no-noise, in these cases the above estimates do not work
562563
//
563564
if((proportion_flat > 1.0f) && (proportion_next > 0.00001f)){
564-
565565
std::cout << "AUTOPARAMTERS:**Warning** Detected that there is likely noisy background, instead assuming background subtracted and minimum signal of 5 (absolute), if this is not the case please set parameters manually" << std::endl;
566566
this->par.Ip_th = 1;
567567
this->par.sigma_th = 5;
@@ -570,7 +570,6 @@ void APRConverter<ImageType>::auto_parameters(const MeshData<T>& input_img){
570570
this->par.rel_error = 0.125;
571571
this->par.min_signal = 5;
572572
this->par.SNR_min = 1;
573-
574573
} else {
575574
std::cout << "AUTOPARAMTERS: **Assuming image has atleast 5% dark background" << std::endl;
576575
}

src/data_structures/APR/ExtraParticleData.hpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
#define PARTPLAY_EXTRAPARTICLEDATA_HPP
77

88

9+
#include <algorithm>
10+
11+
912
template<typename V> class APR;
1013
template<typename V> class APRIterator;
1114

0 commit comments

Comments
 (0)