Add confirmation prompt before closing terminal tabs (#1655)

Author: bajrangCoder

src/components/terminal/terminalDefaults.js

@@ -14,6 +14,7 @@ export const DEFAULT_TERMINAL_SETTINGS = {
 	letterSpacing: 0,
 	imageSupport: false,
 	fontLigatures: false,
+	confirmTabClose: true,
 	// Touch selection settings
 	touchSelectionTapHoldDuration: 600,
 	touchSelectionMoveThreshold: 8,

src/components/terminal/terminalManager.js

@@ -7,6 +7,8 @@ import EditorFile from "lib/editorFile";
 import TerminalComponent from "./terminal";
 import "@xterm/xterm/css/xterm.css";
 import toast from "components/toast";
+import confirm from "dialogs/confirm";
+import appSettings from "lib/settings";
 import helpers from "utils/helpers";
 
 const TERMINAL_SESSION_STORAGE_KEY = "acodeTerminalSessions";
@@ -413,6 +415,22 @@ class TerminalManager {
 			this.closeTerminal(terminalId);
 		};
 
+		terminalFile._skipTerminalCloseConfirm = false;
+		const originalRemove = terminalFile.remove.bind(terminalFile);
+		terminalFile.remove = async (force = false) => {
+			if (
+				!terminalFile._skipTerminalCloseConfirm &&
+				this.shouldConfirmTerminalClose()
+			) {
+				const message = `${strings["close"]} ${strings["terminal"]}?`;
+				const shouldClose = await confirm(strings["confirm"], message);
+				if (!shouldClose) return;
+			}
+
+			terminalFile._skipTerminalCloseConfirm = false;
+			return originalRemove(force);
+		};
+
 		// Enhanced resize handling with debouncing
 		let resizeTimeout = null;
 		const RESIZE_DEBOUNCE = 200;
@@ -519,6 +537,7 @@ class TerminalManager {
 			}
 
 			this.closeTerminal(terminalId);
+			terminalFile._skipTerminalCloseConfirm = true;
 			terminalFile.remove(true);
 			toast(message);
 		};
@@ -731,6 +750,14 @@ class TerminalManager {
 			}
 		});
 	}
+
+	shouldConfirmTerminalClose() {
+		const settings = appSettings?.value?.terminalSettings;
+		if (settings && settings.confirmTabClose === false) {
+			return false;
+		}
+		return true;
+	}
 }
 
 // Create singleton instance

src/settings/terminalSettings.js

@@ -165,6 +165,12 @@ export default function terminalSettings() {
 			checkbox: terminalValues.fontLigatures,
 			info: "Whether font ligatures are enabled in the terminal.",
 		},
+		{
+			key: "confirmTabClose",
+			text: `${strings["confirm"]} ${strings["terminal"]} tab close`,
+			checkbox: terminalValues.confirmTabClose !== false,
+			info: "Ask for confirmation before closing terminal tabs.",
+		},
 		{
 			key: "backup",
 			text: strings.backup.capitalize(),