Skip to content

Conversation

@peterkutz
Copy link
Contributor

This PR removes the upper bound on the supported range of values for subsurface_radius_scale. This lets this parameter be used to decrease the volume density, not just increase it.

Copy link
Contributor

@virtualzavie virtualzavie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrienHerubel
Copy link
Contributor

Should this change target a fix or a feature branch ? And is not that redundant with subsurface_radius ?

@portsmouth
Copy link
Contributor

I'm not sure I'm comfortable with the idea of this PR. Currently the subsurface_radius is supposed to define the length scale of the mean free path, with the subsurface_radius_scale applying a per-channel modulation to this. The color which is entered is similar, though not identical, to the color seen in thin areas which transmit.

It seems a bit unintuitive to allow for arbitrarily high HDR color components, since then the resulting "color" will generally have no relation to the color seen in the render. It's also redundant with the current functionality, and doesn't seem much of a convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants