Fix: 0 was considered as empty value

lgtaxn · lgtaxn · commit 203bb5c199b2 · 2024-06-27T14:30:45.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ UNRELEASED
 ------------------
 
 - Fix unexpected behavior with comments
+- Fix: 0 was considered as empty value
 
 
 1.1.1 (2024-06-24)
diff --git a/src/Converter.php b/src/Converter.php
@@ -443,7 +443,7 @@ protected static function canUseNameAsId(string $name): bool
 
     protected static function isEmpty(string $value): bool
     {
-        return empty($value) || \in_array(strtolower($value), ["''", '""', 'false', 'null']);
+        return \in_array(strtolower($value), ['', "''", '""', 'false', 'null']);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ protected static function canUseNameAsId(string $name): bool`
`443`	`443`
`444`	`444`	`protected static function isEmpty(string $value): bool`
`445`	`445`	`{`
`446`		`- return empty($value) \|\| \in_array(strtolower($value), ["''", '""', 'false', 'null']);`
	`446`	`+ return \in_array(strtolower($value), ['', "''", '""', 'false', 'null']);`
`447`	`447`	`}`
`448`	`448`
`449`	`449`	`/**`