Cleanup license stuff

ATrefzer · ATrefzer · commit a8d5af6bbe14 · 2025-10-19T11:22:38.000+02:00
Refactored unit tests
diff --git a/CSharpCodeAnalyst.sln b/CSharpCodeAnalyst.sln
@@ -13,7 +13,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CodeParser", "CodeParser\Co
 		{7D5EA751-84A3-43F1-BCCE-C9D10536AB1B} = {7D5EA751-84A3-43F1-BCCE-C9D10536AB1B}
 	EndProjectSection
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CodeParserTests", "CodeParserTests\CodeParserTests.csproj", "{F91511F4-5523-4886-BB60-7A8864A621C9}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tests", "Tests\Tests.csproj", "{F91511F4-5523-4886-BB60-7A8864A621C9}"
 	ProjectSection(ProjectDependencies) = postProject
 		{7D5EA751-84A3-43F1-BCCE-C9D10536AB1B} = {7D5EA751-84A3-43F1-BCCE-C9D10536AB1B}
 		{E445DF38-70F2-4972-9567-6591E1E3C833} = {E445DF38-70F2-4972-9567-6591E1E3C833}
diff --git a/CSharpCodeAnalyst/CSharpCodeAnalyst.csproj b/CSharpCodeAnalyst/CSharpCodeAnalyst.csproj
@@ -181,6 +181,14 @@
     </ItemGroup>
 
     <ItemGroup>
+
+        <!-- Copy LICENSE file to output directory -->
+        <None Include="..\LICENSE">
+            <Link>LICENSE</Link>
+            <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+        </None>
+        
+        
         <!-- Copy ThirdPartyNotices to output directory for license compliance -->
         <None Include="..\ThirdPartyNotices\**\*">
             <Link>ThirdPartyNotices\%(RecursiveDir)%(FileName)%(Extension)</Link>
diff --git a/CSharpCodeAnalyst/MainViewModel.cs b/CSharpCodeAnalyst/MainViewModel.cs
@@ -1032,6 +1032,9 @@ private void OnSnapshot()
 
     private void OnRestore()
     {
+        // Note we do not touch the dirty flags when restoring.
+        // If you refactored a new file to save is already requested.
+        // If not, nothing you did with the application triggered the dirty flag.
         _project.RestoreSnapshot(RestoreProjectData);
     }
 
diff --git a/CSharpCodeAnalyst/board.txt b/CSharpCodeAnalyst/board.txt
@@ -15,7 +15,6 @@
 
 
 - Collapsed nodes should be recognized
-- Snapshots / restore do no care about storage state. Is this ok?
 
 
 
diff --git a/CodeParserTests/UnitTests/AnalysisTests.cs b/CodeParserTests/UnitTests/AnalysisTests.cs
diff --git a/LICENSE.txt b/LICENSE.txt
diff --git a/README.md b/README.md
@@ -91,6 +91,7 @@ You can explore scenarios such as:
 
 - What happens if you remove a code element?
 - What happens if you move a class to another namespace?
+- What happens if you cut a dependency between two code elements?
 
 After your modifications, you can rerun the cycle search to observe the impact.
 
@@ -105,6 +106,10 @@ Context Menu Options:
 - **Set as movement parent** – Sets the current element as the parent for subsequent move operations.
 - **Move** – Once a movement parent is set, this option moves the selected element and all its children to the chosen parent.
 
+Additionally in the Code Explorer
+
+- **Delete edge from model** – Deletes the relationships between two code elements. If the edge is bundled, multiple relationships get deleted.
+
 ## Validate your architectural rules
 
 You can define architectural rules and check if they are violated.
diff --git a/Tests/ApprovalTests/ApprovalTestBase.cs b/Tests/ApprovalTests/ApprovalTestBase.cs
@@ -3,7 +3,7 @@
 using CodeParser.Parser.Config;
 using Contracts.Graph;
 
-namespace CodeParserTests;
+namespace CodeParserTests.ApprovalTests;
 
 public class ResolvedRelationship
 {
@@ -59,7 +59,7 @@ public static async Task<CodeGraph> LoadAsync()
 ///     Base class for project-focused approval tests.
 ///     Provides common filtering and assertion methods.
 /// </summary>
-public abstract class ProjectTestBase
+public abstract class ApprovalTestBase
 {
 
     protected CodeGraph Graph = null!;
diff --git a/Tests/ApprovalTests/BasicLanguageFeaturesApprovalTests.cs b/Tests/ApprovalTests/BasicLanguageFeaturesApprovalTests.cs
@@ -3,7 +3,7 @@
 namespace CodeParserTests.ApprovalTests;
 
 [TestFixture]
-public class BasicLanguageFeaturesApprovalTests : ProjectTestBase
+public class BasicLanguageFeaturesApprovalTests : ApprovalTestBase
 {
 
     [Test]
diff --git a/Tests/ApprovalTests/CodeExplorerApprovalTests.cs b/Tests/ApprovalTests/CodeExplorerApprovalTests.cs
@@ -2,7 +2,7 @@
 
 namespace CodeParserTests.ApprovalTests;
 
-public class CodeExplorerApprovalTests : ProjectTestBase
+public class CodeExplorerApprovalTests : ApprovalTestBase
 {
     [Test]
     public void CodeExplorer_FollowIncomingCalls_1()
diff --git a/Tests/ApprovalTests/CyclesApprovalTests.cs b/Tests/ApprovalTests/CyclesApprovalTests.cs
@@ -5,7 +5,7 @@
 namespace CodeParserTests.ApprovalTests;
 
 [TestFixture]
-public class CyclesApprovalTests : ProjectTestBase
+public class CyclesApprovalTests : ApprovalTestBase
 {
     private CodeGraph GetTestAssemblyGraph()
     {
diff --git a/Tests/ApprovalTests/EventsApprovalTests.cs b/Tests/ApprovalTests/EventsApprovalTests.cs
@@ -3,7 +3,7 @@
 namespace CodeParserTests.ApprovalTests;
 
 [TestFixture]
-public class EventsApprovalTests : ProjectTestBase
+public class EventsApprovalTests : ApprovalTestBase
 {
     private CodeGraph GetTestGraph()
     {
diff --git a/Tests/ApprovalTests/GenericsApprovalTests.cs b/Tests/ApprovalTests/GenericsApprovalTests.cs
@@ -3,7 +3,7 @@
 namespace CodeParserTests.ApprovalTests;
 
 [TestFixture]
-public class GenericsApprovalTests : ProjectTestBase
+public class GenericsApprovalTests : ApprovalTestBase
 {
     private CodeGraph GetTestAssemblyGraph()
     {
diff --git a/Tests/ApprovalTests/MethodGroupApprovalTests.cs b/Tests/ApprovalTests/MethodGroupApprovalTests.cs
@@ -6,7 +6,7 @@ namespace CodeParserTests.ApprovalTests;
 ///     Focused approval tests for method group functionality.
 /// </summary>
 [TestFixture]
-public class MethodGroupApprovalTests : ProjectTestBase
+public class MethodGroupApprovalTests : ApprovalTestBase
 {
 
     private CodeGraph GetTestAssemblyGraph()
diff --git a/Tests/ApprovalTests/ModuleLevelApprovalTests.cs b/Tests/ApprovalTests/ModuleLevelApprovalTests.cs
@@ -4,7 +4,7 @@
 namespace CodeParserTests.ApprovalTests;
 
 [TestFixture]
-public class ModuleLevelApprovalTests : ProjectTestBase
+public class ModuleLevelApprovalTests : ApprovalTestBase
 {
 
     private CodeGraph GetTestAssemblyGraph()
diff --git a/Tests/ApprovalTests/NamespacesApprovalTests.cs b/Tests/ApprovalTests/NamespacesApprovalTests.cs
@@ -3,7 +3,7 @@
 namespace CodeParserTests.ApprovalTests;
 
 [TestFixture]
-public class NamespacesApprovalTests : ProjectTestBase
+public class NamespacesApprovalTests : ApprovalTestBase
 {
     private CodeGraph GetTestAssemblyGraph()
     {
diff --git a/Tests/ApprovalTests/ObjectOrientedApprovalTests.cs b/Tests/ApprovalTests/ObjectOrientedApprovalTests.cs
@@ -5,7 +5,7 @@
 namespace CodeParserTests.ApprovalTests;
 
 [TestFixture]
-public class ObjectOrientedApprovalTests : ProjectTestBase
+public class ObjectOrientedApprovalTests : ApprovalTestBase
 {
     private CodeGraph GetTestAssemblyGraph()
     {
diff --git a/Tests/ApprovalTests/OldCSharpLanguageApprovalTests.cs b/Tests/ApprovalTests/OldCSharpLanguageApprovalTests.cs
@@ -7,7 +7,7 @@ namespace CodeParserTests.ApprovalTests;
 /// <summary>
 ///     Old legacy tests
 /// </summary>
-public class OldCSharpLanguageApprovalTests : ProjectTestBase
+public class OldCSharpLanguageApprovalTests : ApprovalTestBase
 {
     private CodeGraph GetTestAssemblyGraph()
     {
diff --git a/Tests/ApprovalTests/RegressionApprovalTests.cs b/Tests/ApprovalTests/RegressionApprovalTests.cs
@@ -3,7 +3,7 @@
 namespace CodeParserTests.ApprovalTests;
 
 [TestFixture]
-public class RegressionApprovalTests : ProjectTestBase
+public class RegressionApprovalTests : ApprovalTestBase
 {
     private CodeGraph GetTestAssemblyGraph()
     {
diff --git a/Tests/ApprovalTests/SolutionApprovalTest.cs b/Tests/ApprovalTests/SolutionApprovalTest.cs
@@ -3,7 +3,7 @@
 namespace CodeParserTests.ApprovalTests;
 
 [TestFixture]
-public class SolutionApprovalTests : ProjectTestBase
+public class SolutionApprovalTests : ApprovalTestBase
 {
 
     [Test]
diff --git a/Tests/GlobalSuppressions.cs b/Tests/GlobalSuppressions.cs
diff --git a/Tests/Helper/TestCodeGraph.cs b/Tests/Helper/TestCodeGraph.cs
diff --git a/Tests/Search/PascalCaseSearchTests.cs b/Tests/Search/PascalCaseSearchTests.cs
@@ -1,6 +1,6 @@
 ﻿using CSharpCodeAnalyst.Common;
 
-namespace CodeParserTests.UnitTests;
+namespace CodeParserTests.Search;
 
 [TestFixture]
 public class PascalCaseSearchTests
diff --git a/Tests/Tests.csproj b/Tests/Tests.csproj
@@ -7,6 +7,7 @@
 
         <IsPackable>false</IsPackable>
         <IsTestProject>true</IsTestProject>
+        <RootNamespace>CodeParserTests</RootNamespace>
     </PropertyGroup>
 
     <ItemGroup>
diff --git a/Tests/UnitTests/ArchitecturalRules/AnalyzerIntegrationTests.cs b/Tests/UnitTests/ArchitecturalRules/AnalyzerIntegrationTests.cs
diff --git a/Tests/UnitTests/ArchitecturalRules/PatternMatcherTests.cs b/Tests/UnitTests/ArchitecturalRules/PatternMatcherTests.cs
diff --git a/Tests/UnitTests/ArchitecturalRules/RuleParserTests.cs b/Tests/UnitTests/ArchitecturalRules/RuleParserTests.cs
diff --git a/Tests/UnitTests/ArchitecturalRules/RuleValidationTests.cs b/Tests/UnitTests/ArchitecturalRules/RuleValidationTests.cs
diff --git a/Tests/UnitTests/Cycles/CodeGraphBuilderTests.cs b/Tests/UnitTests/Cycles/CodeGraphBuilderTests.cs
@@ -1,7 +1,7 @@
 ﻿using CodeParser.Analysis.Cycles;
 using Contracts.Graph;
 
-namespace CodeParserTests.UnitTests;
+namespace CodeParserTests.UnitTests.Cycles;
 
 /// <summary>
 ///     Assumes the SearchGraphBuilder test are ok.
diff --git a/Tests/UnitTests/Cycles/CycleFinderTests.cs b/Tests/UnitTests/Cycles/CycleFinderTests.cs
@@ -4,7 +4,7 @@
 
 // ReSharper disable InconsistentNaming
 
-namespace CodeParserTests.UnitTests;
+namespace CodeParserTests.UnitTests.Cycles;
 
 [TestFixture]
 public class CycleFinderTests
@@ -330,4 +330,64 @@ public void FindMultipleCyclesInGraph()
         Assert.AreEqual(2, groups[0].CodeGraph.Nodes.Count);
         Assert.AreEqual(2, groups[1].CodeGraph.Nodes.Count);
     }
+
+    /// <summary>
+    ///     This is an older test moved to this file.
+    /// </summary>
+    [Test]
+    public void FindStronglyConnectedComponents_ShouldFindSCC()
+    {
+        // Arrange
+        var codeStructure = CreateCodeGraphForShouldFindScc();
+
+        // Act
+        var sccs = CycleFinder.FindCycleGroups(codeStructure);
+
+        // Assert
+        Assert.AreEqual(1, sccs.Count); // We expect one SCC
+        var scc = sccs[0];
+        Assert.AreEqual(3, scc.CodeGraph.Nodes.Values.Count);
+        Assert.True(scc.CodeGraph.Nodes.ContainsKey("A"));
+        Assert.True(scc.CodeGraph.Nodes.ContainsKey("B"));
+        Assert.True(scc.CodeGraph.Nodes.ContainsKey("C"));
+    }
+
+    private static CodeGraph CreateCodeGraphForShouldFindScc()
+    {
+        var codeStructure = new CodeGraph();
+
+        // Create nodes
+        var nodeA = new CodeElement("A", CodeElementType.Class,
+            "ClassA",
+            "", null);
+        var nodeB = new CodeElement("B", CodeElementType.Class,
+            "ClassB",
+            "", null);
+        var nodeC = new CodeElement("C", CodeElementType.Class,
+            "ClassC",
+            "", null);
+        var nodeD = new CodeElement("D", CodeElementType.Class,
+            "ClassD",
+            "", null);
+
+        // Create dependencies to form a cycle: A -> B -> C -> A
+        nodeA.Relationships.Add(new Relationship("A",
+            "B", RelationshipType.Calls));
+        nodeB.Relationships.Add(new Relationship("B",
+            "C", RelationshipType.Calls));
+        nodeC.Relationships.Add(new Relationship("C",
+            "A", RelationshipType.Calls));
+
+        // Additional dependency: D -> A (to ensure D is not part of the SCC)
+        nodeD.Relationships.Add(new Relationship("D",
+            "A", RelationshipType.Calls));
+
+        // Add nodes to the code graph
+        codeStructure.Nodes["A"] = nodeA;
+        codeStructure.Nodes["B"] = nodeB;
+        codeStructure.Nodes["C"] = nodeC;
+        codeStructure.Nodes["D"] = nodeD;
+
+        return codeStructure;
+    }
 }
diff --git a/Tests/UnitTests/Cycles/TarjanTests.cs b/Tests/UnitTests/Cycles/TarjanTests.cs
@@ -1,7 +1,7 @@
 ﻿using CodeParser.Analysis.Cycles;
 using CodeParser.Analysis.Shared;
 
-namespace CodeParserTests.UnitTests;
+namespace CodeParserTests.UnitTests.Cycles;
 
 [TestFixture]
 public class TarjanTests
diff --git a/Tests/UnitTests/Export/PlantUmlExportTests.cs b/Tests/UnitTests/Export/PlantUmlExportTests.cs
@@ -1,11 +1,8 @@
 using CodeParser.Export;
 using CodeParserTests.Helper;
 using Contracts.Graph;
-using Microsoft.Build.Tasks.Deployment.ManifestUtilities;
-using System.Linq;
-using System.Xml.Linq;
 
-namespace CodeParserTests.UnitTests;
+namespace CodeParserTests.UnitTests.Export;
 
 [TestFixture]
 public class PlantUmlExportTests
diff --git a/Tests/UnitTests/Import/JdepsReaderTest.cs b/Tests/UnitTests/Import/JdepsReaderTest.cs

Original file line number	Diff line number	Diff line change
`@@ -1032,6 +1032,9 @@ private void OnSnapshot()`
`1032`	`1032`
`1033`	`1033`	`private void OnRestore()`
`1034`	`1034`	`{`
	`1035`	`+ // Note we do not touch the dirty flags when restoring.`
	`1036`	`+ // If you refactored a new file to save is already requested.`
	`1037`	`+ // If not, nothing you did with the application triggered the dirty flag.`
`1035`	`1038`	`_project.RestoreSnapshot(RestoreProjectData);`
`1036`	`1039`	`}`
`1037`	`1040`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`
`16`	`16`
`17`	`17`	`- Collapsed nodes should be recognized`
`18`		`-- Snapshots / restore do no care about storage state. Is this ok?`
`19`	`18`
`20`	`19`
`21`	`20`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`using CodeParser.Parser.Config;`
`4`	`4`	`using Contracts.Graph;`
`5`	`5`
`6`		`-namespace CodeParserTests;`
	`6`	`+namespace CodeParserTests.ApprovalTests;`
`7`	`7`
`8`	`8`	`public class ResolvedRelationship`
`9`	`9`	`{`
`@@ -59,7 +59,7 @@ public static async Task<CodeGraph> LoadAsync()`
`59`	`59`	`/// Base class for project-focused approval tests.`
`60`	`60`	`/// Provides common filtering and assertion methods.`
`61`	`61`	`/// </summary>`
`62`		`-public abstract class ProjectTestBase`
	`62`	`+public abstract class ApprovalTestBase`
`63`	`63`	`{`
`64`	`64`
`65`	`65`	`protected CodeGraph Graph = null!;`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`namespace CodeParserTests.ApprovalTests;`
`4`	`4`
`5`	`5`	`[TestFixture]`
`6`		`-public class BasicLanguageFeaturesApprovalTests : ProjectTestBase`
	`6`	`+public class BasicLanguageFeaturesApprovalTests : ApprovalTestBase`
`7`	`7`	`{`
`8`	`8`
`9`	`9`	`[Test]`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace CodeParserTests.ApprovalTests;`
`4`	`4`
`5`		`-public class CodeExplorerApprovalTests : ProjectTestBase`
	`5`	`+public class CodeExplorerApprovalTests : ApprovalTestBase`
`6`	`6`	`{`
`7`	`7`	`[Test]`
`8`	`8`	`public void CodeExplorer_FollowIncomingCalls_1()`