Skip to content

Commit 1fea843

Browse files
arcanedev-marocarcanedev-maroc
authored
Merge pull request #29 from ARCANEDEV/update-package
Updating the package
2 parents 78ee2c1 + 5599323 commit 1fea843

File tree

6 files changed

+24
-49
lines changed

6 files changed

+24
-49
lines changed

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ This Laravel Notes will allow you to add a notes system into your Laravel projec
2020
* Easy setup & configuration.
2121
* Well documented & IDE Friendly.
2222
* Well tested with maximum code quality.
23-
* Laravel `5.1` to `6.0` are supported.
23+
* Laravel `5.1` to `6.x` are supported.
2424
* Made with :heart: & :coffee:.
2525

2626
## Table of contents
@@ -42,7 +42,7 @@ If you discover any security related issues, please email arcanedev.maroc@gmail.
4242
- [ARCANEDEV][link-author]
4343
- [All Contributors][link-contributors]
4444

45-
[badge_laravel]: https://img.shields.io/badge/For%20Laravel-5.1%20to%206.0-orange.svg?style=flat-square
45+
[badge_laravel]: https://img.shields.io/badge/For%20Laravel-5.1%20to%206.x-orange.svg?style=flat-square
4646
[badge_license]: https://img.shields.io/packagist/l/arcanedev/laravel-notes.svg?style=flat-square
4747
[badge_build]: https://img.shields.io/travis/ARCANEDEV/LaravelNotes.svg?style=flat-square
4848
[badge_coverage]: https://img.shields.io/scrutinizer/coverage/g/ARCANEDEV/LaravelNotes.svg?style=flat-square

‎_docs/0-Home.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This Laravel Notes will allow you to add a notes system into your Laravel projec
88
* Easy setup & configuration.
99
* Well documented & IDE Friendly.
1010
* Well tested with maximum code quality.
11-
* Laravel `5.1` to `6.0` are supported.
11+
* Laravel `5.1` to `6.x` are supported.
1212
* Made with :heart: & :coffee:.
1313

1414
## Table of contents

‎_docs/1-Installation-and-Setup.md‎

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,6 @@
66
2. [Configuration](2-Configuration.md)
77
3. [Usage](3-Usage.md)
88

9-
## Server Requirements
10-
11-
The Laravel Notes package has a few system requirements:
12-
13-
```
14-
- PHP >= 7.1.3
15-
```
16-
179
## Version Compatibility
1810

1911
| Laravel Notes | Laravel |
@@ -24,7 +16,7 @@ The Laravel Notes package has a few system requirements:
2416
| ![Laravel Notes v3.x][laravel_notes_3_x] | ![Laravel v5.6][laravel_5_6] |
2517
| ![Laravel Notes v4.x][laravel_notes_4_x] | ![Laravel v5.7][laravel_5_7] |
2618
| ![Laravel Notes v5.x][laravel_notes_5_x] | ![Laravel v5.8][laravel_5_8] |
27-
| ![Laravel Notes v6.x][laravel_notes_6_x] | ![Laravel v6.0][laravel_6_0] |
19+
| ![Laravel Notes v6.x][laravel_notes_6_x] | ![Laravel v6.x][laravel_6_x] |
2820

2921
[laravel_5_1]: https://img.shields.io/badge/v5.1-supported-brightgreen.svg?style=flat-square "Laravel v5.1"
3022
[laravel_5_2]: https://img.shields.io/badge/v5.2-supported-brightgreen.svg?style=flat-square "Laravel v5.2"
@@ -34,15 +26,15 @@ The Laravel Notes package has a few system requirements:
3426
[laravel_5_6]: https://img.shields.io/badge/v5.6-supported-brightgreen.svg?style=flat-square "Laravel v5.6"
3527
[laravel_5_7]: https://img.shields.io/badge/v5.7-supported-brightgreen.svg?style=flat-square "Laravel v5.7"
3628
[laravel_5_8]: https://img.shields.io/badge/v5.8-supported-brightgreen.svg?style=flat-square "Laravel v5.8"
37-
[laravel_6_0]: https://img.shields.io/badge/v6.0-supported-brightgreen.svg?style=flat-square "Laravel v6.0"
38-
39-
[laravel_notes_0_x]: https://img.shields.io/badge/version-0.*-blue.svg?style=flat-square "LaravelNotes v0.*"
40-
[laravel_notes_1_x]: https://img.shields.io/badge/version-1.*-blue.svg?style=flat-square "LaravelNotes v1.*"
41-
[laravel_notes_2_x]: https://img.shields.io/badge/version-2.*-blue.svg?style=flat-square "LaravelNotes v2.*"
42-
[laravel_notes_3_x]: https://img.shields.io/badge/version-3.*-blue.svg?style=flat-square "LaravelNotes v3.*"
43-
[laravel_notes_4_x]: https://img.shields.io/badge/version-4.*-blue.svg?style=flat-square "LaravelNotes v4.*"
44-
[laravel_notes_5_x]: https://img.shields.io/badge/version-5.*-blue.svg?style=flat-square "LaravelNotes v5.*"
45-
[laravel_notes_6_x]: https://img.shields.io/badge/version-6.*-blue.svg?style=flat-square "LaravelNotes v6.*"
29+
[laravel_6_x]: https://img.shields.io/badge/v6.x-supported-brightgreen.svg?style=flat-square "Laravel v6.x"
30+
31+
[laravel_notes_0_x]: https://img.shields.io/badge/version-0.x-blue.svg?style=flat-square "LaravelNotes v0.x"
32+
[laravel_notes_1_x]: https://img.shields.io/badge/version-1.x-blue.svg?style=flat-square "LaravelNotes v1.x"
33+
[laravel_notes_2_x]: https://img.shields.io/badge/version-2.x-blue.svg?style=flat-square "LaravelNotes v2.x"
34+
[laravel_notes_3_x]: https://img.shields.io/badge/version-3.x-blue.svg?style=flat-square "LaravelNotes v3.x"
35+
[laravel_notes_4_x]: https://img.shields.io/badge/version-4.x-blue.svg?style=flat-square "LaravelNotes v4.x"
36+
[laravel_notes_5_x]: https://img.shields.io/badge/version-5.x-blue.svg?style=flat-square "LaravelNotes v5.x"
37+
[laravel_notes_6_x]: https://img.shields.io/badge/version-6.x-blue.svg?style=flat-square "LaravelNotes v6.x"
4638

4739
## Composer
4840

‎composer.json‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@
1515
"license": "MIT",
1616
"require": {
1717
"php": ">=7.2.0",
18-
"arcanedev/support": "~5.0.0"
18+
"arcanedev/support": "^5.0"
1919
},
2020
"require-dev": {
21-
"orchestra/testbench": "~4.0.0",
22-
"mockery/mockery": "~1.0",
23-
"phpunit/phpunit": "~8.0",
24-
"phpunit/phpcov": "~6.0"
21+
"orchestra/testbench": "^4.0",
22+
"mockery/mockery": "^1.0",
23+
"phpunit/phpunit": "^8.0",
24+
"phpunit/phpcov": "^6.0"
2525
},
2626
"autoload": {
2727
"psr-4": {

‎src/LaravelNotesServiceProvider.php‎

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php namespace Arcanedev\LaravelNotes;
22

3-
use Arcanedev\Support\PackageServiceProvider;
3+
use Arcanedev\Support\Providers\PackageServiceProvider;
44

55
/**
66
* Class LaravelNotesServiceProvider
@@ -30,7 +30,7 @@ class LaravelNotesServiceProvider extends PackageServiceProvider
3030
/**
3131
* Register the service provider.
3232
*/
33-
public function register()
33+
public function register(): void
3434
{
3535
parent::register();
3636

@@ -40,21 +40,10 @@ public function register()
4040
/**
4141
* Boot the service provider.
4242
*/
43-
public function boot()
43+
public function boot(): void
4444
{
45-
parent::boot();
46-
4745
$this->publishConfig();
48-
LaravelNotes::$publishMigrations ? $this->publishMigrations() : $this->loadMigrations();
49-
}
5046

51-
/**
52-
* Get the services provided by the provider.
53-
*
54-
* @return array
55-
*/
56-
public function provides()
57-
{
58-
return [];
47+
LaravelNotes::$publishMigrations ? $this->publishMigrations() : $this->loadMigrations();
5948
}
6049
}

‎tests/LaravelNotesServiceProviderTest.php‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,13 @@ public function it_can_be_instantiated()
4747
{
4848
$expectations = [
4949
\Illuminate\Support\ServiceProvider::class,
50-
\Arcanedev\Support\ServiceProvider::class,
51-
\Arcanedev\Support\PackageServiceProvider::class,
50+
\Arcanedev\Support\Providers\ServiceProvider::class,
51+
\Arcanedev\Support\Providers\PackageServiceProvider::class,
5252
LaravelNotesServiceProvider::class,
5353
];
5454

5555
foreach ($expectations as $expected) {
5656
static::assertInstanceOf($expected, $this->provider);
5757
}
5858
}
59-
60-
/** @test */
61-
public function it_can_provides()
62-
{
63-
static::assertSame([], $this->provider->provides());
64-
}
6559
}

0 commit comments

Comments
 (0)