Decouple fuzzer functions from event manager (#2915)

* decouple fuzzer from em

* lol

* 3

* fix tcp

* fix

* fix

* fix

* fixer

* std

* fixer

* plz

* plzplzplz

* plzplzplzplz

* mm

* more

* symbol

* a

* a

* mm

* mmm

* mmmm

* mmmmm

* ff

Author: tokatoka

MIGRATION.md

@@ -1,3 +1,10 @@
+# 0.15.0 -> 0.16.0
+- `EventManager` is refactored to avoid calling function from `Fuzzer`, thus we do not evaluate testcases in `EventManager` anymore.
+  - Now we have `EventReceiver` in `events` module, and `EventProessor` in `fuzzer` module.
+  - `EventReceiver` is responsible for receiving testcases and delegates its evaluation to `EventProcessor`.
+  - `EventProcessor` is responsible for evaluating the testcases passed by the `EventReceiver`.
+  - Since we don't evaluate testcases in the `EventManager` anymore. `on_fire` and `post_exec` have been deleted from `EventManagerHook`.
+  - Similarly `pre_exec` has been renamed to `pre_receive`.
 
 # 0.14.1 -> 0.15.0
 - `MmapShMem::new` and `MmapShMemProvider::new_shmem_with_id` now take `AsRef<Path>` instead of a byte array for the filename/id.

fuzzers/baby/baby_fuzzer_custom_executor/src/main.rs

@@ -7,7 +7,7 @@ use libafl::monitors::tui::TuiMonitor;
 #[cfg(not(feature = "tui"))]
 use libafl::monitors::SimpleMonitor;
 use libafl::{
-    corpus::{Corpus, InMemoryCorpus, OnDiskCorpus},
+    corpus::{InMemoryCorpus, OnDiskCorpus},
     events::SimpleEventManager,
     executors::{Executor, ExitKind, WithObservers},
     feedback_and_fast,

fuzzers/baby/baby_fuzzer_unicode/src/main.rs

@@ -123,7 +123,7 @@ pub fn main() {
             &mut state,
             &mut executor,
             &mut mgr,
-            BytesInput::new(vec![b'a']),
+            &BytesInput::new(vec![b'a']),
         )
         .unwrap();
 

fuzzers/forkserver/libafl-fuzz/src/fuzzer.rs

@@ -78,7 +78,6 @@ pub type LibaflFuzzState =
 #[cfg(not(feature = "fuzzbench"))]
 type LibaflFuzzManager = CentralizedEventManager<
     LlmpRestartingEventManager<(), BytesInput, LibaflFuzzState, StdShMem, StdShMemProvider>,
-    (),
     BytesInput,
     LibaflFuzzState,
     StdShMem,

fuzzers/forkserver/libafl-fuzz/src/hooks.rs

@@ -14,7 +14,7 @@ impl<I, S> EventManagerHook<I, S> for LibAflFuzzEventHook
 where
     S: Stoppable,
 {
-    fn pre_exec(
+    fn pre_receive(
         &mut self,
         state: &mut S,
         _client_id: ClientId,
@@ -26,7 +26,4 @@ where
         }
         Ok(true)
     }
-    fn post_exec(&mut self, _state: &mut S, _client_id: ClientId) -> Result<bool, Error> {
-        Ok(true)
-    }
 }

fuzzers/inprocess/libfuzzer_libpng_centralized/src/lib.rs

@@ -141,7 +141,7 @@ pub extern "C" fn libafl_main() {
 
     let mut secondary_run_client =
         |state: Option<_>,
-         mut mgr: CentralizedEventManager<_, _, _, _, _, _>,
+         mut mgr: CentralizedEventManager<_, _, _, _, _>,
          _client_description: ClientDescription| {
             // Create an observation channel using the coverage map
             let edges_observer =

fuzzers/inprocess/sqlite_centralized_multi_machine/src/lib.rs

@@ -157,7 +157,7 @@ pub extern "C" fn libafl_main() {
 
     let mut secondary_run_client =
         |state: Option<_>,
-         mut mgr: CentralizedEventManager<_, _, _, _, _, _>,
+         mut mgr: CentralizedEventManager<_, _, _, _, _>,
          _client_description: ClientDescription| {
             // Create an observation channel using the coverage map
             let edges_observer =

fuzzers/structure_aware/baby_fuzzer_grimoire/src/main.rs

@@ -164,7 +164,7 @@ pub fn main() {
 
     for input in initial_inputs {
         fuzzer
-            .evaluate_input(&mut state, &mut executor, &mut mgr, input)
+            .evaluate_input(&mut state, &mut executor, &mut mgr, &input)
             .unwrap();
     }
 

fuzzers/structure_aware/baby_fuzzer_multi/src/main.rs

@@ -151,7 +151,7 @@ pub fn main() {
     ]);
 
     fuzzer
-        .evaluate_input(&mut state, &mut executor, &mut mgr, initial)
+        .evaluate_input(&mut state, &mut executor, &mut mgr, &initial)
         .unwrap();
 
     // Setup a mutational stage with a basic bytes mutator