Skip to content

Commit 56c353b

Browse files
committed
Dont overwrite err with nil (part go-gitea#19572)
1 parent 755d8e2 commit 56c353b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

services/pull/check.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ var prQueue queue.UniqueQueue
3333

3434
var (
3535
ErrIsClosed = errors.New("pull is cosed")
36-
ErrUserNotAllowedToMerge = errors.New("user not allowed to merge")
36+
ErrUserNotAllowedToMerge = models.ErrNotAllowedToMerge{}
3737
ErrHasMerged = errors.New("has already been merged")
3838
ErrIsWorkInProgress = errors.New("work in progress PRs cannot be merged")
3939
ErrIsChecking = errors.New("cannot merge while conflict checking is in progress")
@@ -96,10 +96,10 @@ func CheckPullMergable(ctx context.Context, doer *user_model.User, perm *models.
9696
if err := CheckPRReadyToMerge(pr, false); err != nil {
9797
if models.IsErrNotAllowedToMerge(err) {
9898
if force {
99-
if isRepoAdmin, err := models.IsUserRepoAdmin(pr.BaseRepo, doer); err != nil {
100-
return err
99+
if isRepoAdmin, err2 := models.IsUserRepoAdmin(pr.BaseRepo, doer); err2 != nil {
100+
return err2
101101
} else if !isRepoAdmin {
102-
return ErrUserNotAllowedToMerge
102+
return err
103103
}
104104
}
105105
} else {

0 commit comments

Comments
 (0)