feat: unify one/ones (#160)

* feat: unify one/ones

* opti

* opti

Author: SuccinctPaul

starky/src/f3g.rs

@@ -61,6 +61,14 @@ impl FieldExtension for F3G {
         dim: 1,
     };
 
+    const ZEROS: Self = F3G {
+        cube: [Fr::ZERO, Fr::ZERO, Fr::ZERO],
+        dim: 3,
+    };
+    const ONES: Self = F3G {
+        cube: [Fr::ONE, Fr::ZERO, Fr::ZERO],
+        dim: 3,
+    };
     #[inline(always)]
     fn dim(&self) -> usize {
         self.dim
@@ -256,18 +264,12 @@ impl ::rand::Rand for F3G {
 impl plonky::Field for F3G {
     #[inline(always)]
     fn zero() -> Self {
-        F3G {
-            cube: [Fr::ZERO, Fr::ZERO, Fr::ZERO],
-            dim: 3,
-        }
+        Self::ZEROS
     }
 
     #[inline(always)]
     fn one() -> Self {
-        F3G {
-            cube: [Fr::ONE, Fr::ZERO, Fr::ZERO],
-            dim: 3,
-        }
+        Self::ONES
     }
 
     #[inline(always)]
@@ -730,7 +732,7 @@ pub mod tests {
 
         let b = a.inv();
         let c = a.mul(b);
-        assert_eq!(c, F3G::one());
+        assert_eq!(c, F3G::ONES);
     }
 
     #[test]

starky/src/f5g.rs

@@ -7,6 +7,7 @@ use std::hash::{Hash, Hasher};
 use std::slice;
 
 use core::fmt::{Display, Formatter};
+
 /// Prime: 0xFFFFFFFF00000001
 /// Irreducible polynomial: x^5-3
 #[repr(C)]
@@ -47,7 +48,14 @@ impl FieldExtension for F5G {
         cube: [Fr::ONE, Fr::ZERO, Fr::ZERO, Fr::ZERO, Fr::ZERO],
         dim: 1,
     };
-
+    const ZEROS: Self = F5G {
+        cube: [Fr::ZERO, Fr::ZERO, Fr::ZERO, Fr::ZERO, Fr::ZERO],
+        dim: 5,
+    };
+    const ONES: Self = F5G {
+        cube: [Fr::ONE, Fr::ZERO, Fr::ZERO, Fr::ZERO, Fr::ZERO],
+        dim: 5,
+    };
     #[inline(always)]
     fn dim(&self) -> usize {
         self.dim
@@ -229,18 +237,12 @@ impl ::rand::Rand for F5G {
 impl plonky::Field for F5G {
     #[inline(always)]
     fn zero() -> Self {
-        F5G {
-            cube: [Fr::ZERO, Fr::ZERO, Fr::ZERO, Fr::ZERO, Fr::ZERO],
-            dim: 1,
-        }
+        Self::ZEROS
     }
 
     #[inline(always)]
     fn one() -> Self {
-        F5G {
-            cube: [Fr::ONE, Fr::ZERO, Fr::ZERO, Fr::ZERO, Fr::ZERO],
-            dim: 1,
-        }
+        Self::ONES
     }
 
     #[inline(always)]

starky/src/traits.rs

@@ -81,6 +81,9 @@ pub trait FieldExtension:
     const IS_CANONICAL: bool = false;
     const ZERO: Self;
     const ONE: Self;
+
+    const ZEROS: Self;
+    const ONES: Self;
     const NEW_SIZE: u64 = 0;
     fn dim(&self) -> usize;
     fn from_vec(values: Vec<Fr>) -> Self;