refactor(core): replace deps installer with manager in plugin manager

Author: Ovidiu Barabula

src/plugin-manager/index.spec.ts

@@ -2,22 +2,20 @@ import { assert, expect } from 'chai';
 import 'mocha';
 import ConfigManager from '../config-manager';
 import ConfigWizard from '../config-wizard';
+import depsManager from '../dependencies-manager';
 import TaskManager from '../task-manager';
-import DependenciesInstaller from '../util/dependencies-installer';
 import PluginManager, { ERRORS } from './index';
 
 describe('PluginManager', () => {
   let taskManager;
   let configWizard;
-  let depsInstaller;
   let validPlugin;
 
   beforeEach(async () => {
     taskManager = TaskManager({
       hooks: ['before', 'midway', 'after'],
     });
     configWizard = ConfigWizard(await ConfigManager());
-    depsInstaller = await DependenciesInstaller.getInstance(process.cwd());
     validPlugin = {
       install: () => true,
       name: 'my-valid-plugin',
@@ -26,7 +24,7 @@ describe('PluginManager', () => {
 
 
   it('instantiates', () => {
-    const pluginManager = PluginManager(taskManager, configWizard, depsInstaller);
+    const pluginManager = PluginManager(taskManager, configWizard, depsManager);
     expect(pluginManager).to.be.an('object').to.contain.keys('use');
   });
 
@@ -46,17 +44,17 @@ describe('PluginManager', () => {
 
 
   it('throws if not passed DependenciesInstaller instance', () => {
-    assert.throws(() => PluginManager(taskManager, configWizard), ERRORS.NO_DEPS_INSTALLER);
-    assert.throws(() => PluginManager(taskManager, configWizard, {}), ERRORS.NO_DEPS_INSTALLER);
-    assert.throws(() => PluginManager(taskManager, configWizard, 1), ERRORS.NO_DEPS_INSTALLER);
+    assert.throws(() => PluginManager(taskManager, configWizard), ERRORS.NO_DEPS_MANAGER);
+    assert.throws(() => PluginManager(taskManager, configWizard, {}), ERRORS.NO_DEPS_MANAGER);
+    assert.throws(() => PluginManager(taskManager, configWizard, 1), ERRORS.NO_DEPS_MANAGER);
   });
 
 
   describe('private method loadPlugin()', () => {
     let pluginManager;
 
     beforeEach(() => {
-      pluginManager = PluginManager(taskManager, configWizard, depsInstaller);
+      pluginManager = PluginManager(taskManager, configWizard, depsManager);
     });
 
 
@@ -81,7 +79,7 @@ describe('PluginManager', () => {
     let pluginManager;
 
     beforeEach(() => {
-      pluginManager = PluginManager(taskManager, configWizard, depsInstaller);
+      pluginManager = PluginManager(taskManager, configWizard, depsManager);
     });
 
 
@@ -130,7 +128,7 @@ describe('PluginManager', () => {
       getSubscribers: () => called = true,
       run: () => undefined,
     };
-    const pluginManager = PluginManager(taskManagerStub, configWizard, depsInstaller);
+    const pluginManager = PluginManager(taskManagerStub, configWizard, depsManager);
     await pluginManager.use(validPlugin);
     expect(called).to.be.true;
   });
@@ -145,20 +143,20 @@ describe('PluginManager', () => {
       start: () => undefined,
     };
 
-    const pluginManager = PluginManager(taskManager, configWizardStub, depsInstaller);
+    const pluginManager = PluginManager(taskManager, configWizardStub, depsManager);
     await pluginManager.use(validPlugin);
     expect(called).to.be.true;
   });
 
 
-  it('calls depsInstaller.getSubscriber() method if plugin is valid', async () => {
+  it('calls depsManager.getSubscriber() method if plugin is valid', async () => {
     let called = false;
 
-    const depsInstallerStub = {
+    const depsManagerStub = {
       getSubscriber: () => called = true,
     };
 
-    const pluginManager = PluginManager(taskManager, configWizard, depsInstallerStub);
+    const pluginManager = PluginManager(taskManager, configWizard, depsManagerStub);
     await pluginManager.use(validPlugin);
     expect(called).to.be.true;
   });
@@ -176,7 +174,7 @@ describe('PluginManager', () => {
       },
     };
 
-    const pluginManager = PluginManager(taskManager, configWizard, depsInstaller);
+    const pluginManager = PluginManager(taskManager, configWizard, depsManager);
     await pluginManager.use(pluginStub);
   });
 });

src/plugin-manager/index.ts

@@ -7,8 +7,8 @@
 
 import * as path from 'path';
 import { IConfigWizard, QuestionnaireSubscriber } from '../config-wizard';
+import { DependenciesManager, DependenciesSubscriber } from '../dependencies-manager';
 import { TaskManager, TaskSubscriber } from '../task-manager';
-import dependenciesInstaller, { DependenciesInstaller, DependenciesSubscriber } from '../util/dependencies-installer';
 import Logger, { ILogger } from '../util/logger';
 import { dynamicRequire, flattenArray, pluginName } from '../util/utility-functions';
 import Installable, { InstallableObject } from './installable';
@@ -34,7 +34,7 @@ export type PluginSubscribers = TaskSubscriber | QuestionnaireSubscriber | Depen
 // Custom error messages
 export const ERRORS = {
   NO_CONFIG_WIZARD: 'PluginManager() requires second argument to be a ConfigWizard instance',
-  NO_DEPS_INSTALLER: 'PluginManager() requires third argument to be a DependenciesInstaller instance',
+  NO_DEPS_MANAGER: 'PluginManager() requires third argument to be a DependenciesManager instance',
   NO_TASK_MANAGER: 'PluginManager() requires first argument to be a TaskManager instance',
   PLUGIN_NAME_SHOULD_BE_STRING: 'PluginManager() passed in plugin name should be a string',
   PLUGIN_NOT_FOUND: 'PluginManager> plugin could not be loaded',
@@ -47,7 +47,7 @@ export const ERRORS = {
 function PluginManager(
   taskManager: TaskManager,
   configWizard: IConfigWizard,
-  depsInstaller: DependenciesInstaller,
+  depsManager: DependenciesManager,
 ): PluginManager {
   const logger: ILogger = Logger.getInstance()('PluginManager');
 
@@ -56,23 +56,23 @@ function PluginManager(
     typeof taskManager !== 'object' ||
     !taskManager.hasOwnProperty('getSubscribers')
   ) {
-    throw new Error(ERRORS.NO_TASK_MANAGER);
+    throw new Error(`${ERRORS.NO_TASK_MANAGER}, ${typeof taskManager} was passed instead`);
   }
 
   if (
     typeof configWizard === 'undefined' ||
     typeof configWizard !== 'object' ||
     !configWizard.hasOwnProperty('getSubscriber')
   ) {
-    throw new Error(ERRORS.NO_CONFIG_WIZARD);
+    throw new Error(`${ERRORS.NO_CONFIG_WIZARD}, ${typeof configWizard} was passed instead`);
   }
 
   if (
-    typeof depsInstaller === 'undefined' ||
-    typeof depsInstaller !== 'object' ||
-    !depsInstaller.hasOwnProperty('getSubscriber')
+    typeof depsManager === 'undefined' ||
+    typeof depsManager !== 'object' ||
+    !depsManager.hasOwnProperty('getSubscriber')
   ) {
-    throw new Error(ERRORS.NO_DEPS_INSTALLER);
+    throw new Error(`${ERRORS.NO_DEPS_MANAGER}, ${typeof depsManager} was passed instead`);
   }
 
 
@@ -136,8 +136,8 @@ function PluginManager(
       taskManager.getSubscribers(),
       // Subscriber for configuration questionnaire registration
       configWizard.getSubscriber(),
-      // Dependencies installer subscribrer
-      depsInstaller.getSubscriber(),
+      // Dependencies manager subscribrer
+      depsManager.getSubscriber(),
     ];
   }